Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX Weirdness] URL Parameter specified twice in Ninetailed class constructor parameters #43

Open
cwkosman opened this issue Apr 5, 2024 · 0 comments
Assignees
Labels
bug Something isn't working triage

Comments

@cwkosman
Copy link

cwkosman commented Apr 5, 2024

Describe the bug
When using the Ninetailed class constructor from the JS SDK, there are two parameters to specify a URL:

  1. a url property in the first object of type ninetailedApiClientInstanceOrOptions
  2. a url property in the second object of type options

Only the second url property is actually used by the constructor.

Expected behavior
A clear and concise description of what you expected to happen.
Have only url parameter. Either:

  1. Remove the url property of the first parameter to keep the code as it functions now, OR
  2. Remove the url property of the second parameter to more closely match the type signature of constructing a NinetailedApiClient

Versions
Please list packages version, browser, node version, etc.
Present on latest 7.x.x package.

Additional context
Add any other context about the problem here.
Code: https://github.com/ninetailed-inc/experience.js/blob/main/packages/sdks/javascript/src/lib/Ninetailed.ts#L102

@cwkosman cwkosman added the bug Something isn't working label Apr 5, 2024
@github-actions github-actions bot added the triage label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

2 participants