We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug When using the Ninetailed class constructor from the JS SDK, there are two parameters to specify a URL:
url
ninetailedApiClientInstanceOrOptions
options
Only the second url property is actually used by the constructor.
Expected behavior A clear and concise description of what you expected to happen. Have only url parameter. Either:
NinetailedApiClient
Versions Please list packages version, browser, node version, etc. Present on latest 7.x.x package.
Additional context Add any other context about the problem here. Code: https://github.com/ninetailed-inc/experience.js/blob/main/packages/sdks/javascript/src/lib/Ninetailed.ts#L102
The text was updated successfully, but these errors were encountered:
BraunreutherA
cwkosman
No branches or pull requests
Describe the bug
When using the Ninetailed class constructor from the JS SDK, there are two parameters to specify a URL:
url
property in the first object of typeninetailedApiClientInstanceOrOptions
url
property in the second object of typeoptions
Only the second
url
property is actually used by the constructor.Expected behavior
A clear and concise description of what you expected to happen.
Have only
url
parameter. Either:url
property of the first parameter to keep the code as it functions now, ORurl
property of the second parameter to more closely match the type signature of constructing aNinetailedApiClient
Versions
Please list packages version, browser, node version, etc.
Present on latest 7.x.x package.
Additional context
Add any other context about the problem here.
Code: https://github.com/ninetailed-inc/experience.js/blob/main/packages/sdks/javascript/src/lib/Ninetailed.ts#L102
The text was updated successfully, but these errors were encountered: