Skip to content

Commit df09e77

Browse files
committed
Make following changes:
- Bump up flyway version - Modify service names, ports and add network in docker-compose file - Modify DB params - Update README file
1 parent 03069ef commit df09e77

File tree

5 files changed

+32
-14
lines changed

5 files changed

+32
-14
lines changed

Dockerfile2

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@ ADD ./wait-for-it.sh wait-for-it.sh
2626

2727
ENTRYPOINT [ "/bin/bash", "-c" ]
2828
# modify 2nd argumet in next (i.e. `CMD`) line
29-
CMD ["/wait-for-it.sh" , "[localhost:5432]" , "--strict" , "--timeout=300" , "--" , "java -jar /app/sb-kotlin-java-app-0.1.jar"]
29+
CMD ["/wait-for-it.sh" , "[localhost:5440]" , "--strict" , "--timeout=300" , "--" , "java -jar /app/sb-kotlin-java-app-0.1.jar"]
3030
#ENTRYPOINT ["java", "-Djava.security.egd=file:/dev/./urandom", "-jar", "/app/sb-kotlin-java-app-0.1.jar"]

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ To properly set up and run the app perform following steps:
2020

2121
## 2. App containerization
2222
If you prefer not to have...
23-
#TODO: Finish this!
23+
#TODO: Finish this!!!!!!!!!!!!!
2424

2525

2626
## 3. REST Endpoints

build.gradle.kts

+4-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ plugins {
66
kotlin("jvm") version "1.5.10"
77
id("org.springframework.boot") version "2.5.0"
88
id("io.spring.dependency-management") version "1.0.11.RELEASE"
9-
id("org.flywaydb.flyway") version "7.9.1"
9+
id("org.flywaydb.flyway") version "7.15.0"
1010
kotlin("plugin.spring") version "1.5.10"
1111
kotlin("plugin.jpa") version "1.5.10"
1212
kotlin("plugin.allopen") version "1.5.10"
@@ -51,10 +51,12 @@ dependencies {
5151
testImplementation("com.ninja-squad:springmockk:3.0.1")
5252
implementation("org.springframework.boot:spring-boot-starter-mustache")
5353
implementation("org.springframework.boot:spring-boot-starter-actuator")
54-
runtimeOnly("org.postgresql:postgresql")
54+
// runtimeOnly("org.postgresql:postgresql")
55+
implementation("org.postgresql:postgresql:42.2.24")
5556
implementation( "org.flywaydb:flyway-core:7.9.1")
5657
kapt("org.springframework.boot:spring-boot-configuration-processor")
5758
implementation("org.springframework.boot:spring-boot-configuration-processor")
59+
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core")
5860
}
5961

6062
tasks.withType<KotlinCompile> {

docker-compose.yml

+24-8
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version: "3.7"
1+
#version: "3.8"
22
# TODO Read following docs:
33
# https://github.com/docker-library/docs/blob/master/postgres/README.md
44
# https://github.com/docker-library/docs/tree/master/openjdk
@@ -9,38 +9,54 @@ version: "3.7"
99
# ****************************************************************************************************************
1010

1111
services:
12-
postgres-db:
12+
postgres_db:
1313
image: postgres:12.9
14-
container_name: postgres-db
14+
restart: always
15+
container_name: postgres_db
1516
volumes:
1617
- postgres-data:/var/lib/postgresql/data
18+
# - postgres-data:/var/lib/postgresql/data
1719
environment:
1820
POSTGRES_USER: postgres
1921
POSTGRES_PASSWORD: postgres
2022
POSTGRES_DB: todo_db
2123
# TODO: try mapping to different host and container ports
24+
networks:
25+
- app_db_net
2226
ports:
2327
- "5440:5432"
24-
- "5441:5440"
2528

2629
app:
27-
image: openjdk:8
30+
#image: openjdk:8
31+
build: .
32+
image: nixos89/todo_app:0.2
33+
container_name: todo_app
2834
depends_on:
29-
- postgres-db
35+
- postgres_db
3036
ports:
3137
- "8080:8080"
3238
volumes:
3339
- ./build/libs:/app
3440
# TODO: modify `command` statement in order to execute
35-
command: wait-for-it.sh localhost:5432 -t 20 && java -jar /app/todo-app-0.1.jar
41+
# command: wait-for-it.sh localhost:5432 -t 20 && java -jar /app/todo-app-0.1.jar
42+
# command: 127.0.0.1:5440 -t 20 && java -jar /app/todo-app-0.1.jar
43+
networks:
44+
- app_db_net
3645
# entrypoint:
3746
environment:
38-
- SPRING_DATASOURCE_URL=jdbc:postgresql://localhost:5432/todo_db
47+
- SPRING_DATASOURCE_URL=jdbc:postgresql://postgres_db:5440/todo_db
3948
- SPRING_DATASOURCE_DRIVER_CLASS_NAME=org.postgresql.Driver
4049
- SPRING_DATASOURCE_USERNAME=postgres
4150
- SPRING_DATASOURCE_PASSWORD=postgres
4251
- SPRING_JPA_HIBERNATE_DDL_AUTO=update
4352
- SPRING_FLYWAY_USER=postgres
4453
- SPRING_FLYWAY_PASSWORD=postgres
54+
55+
networks:
56+
app_db_net:
57+
driver: bridge
58+
# external: true
59+
# name: project
60+
4561
volumes:
4662
postgres-data:

src/main/resources/application.properties

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@ management.endpoints.web.exposure.include=health,info,shutdown
33
#logging.level.root=debug
44

55
# setting up Postgres DB
6-
spring.datasource.url=jdbc:postgresql://localhost:5432/todo_db
6+
spring.datasource.url=jdbc:postgresql://postgres_db:5440/todo_db
77
spring.datasource.username=postgres
88
spring.datasource.password=postgres
99
spring.datasource.driverClassName=org.postgresql.Driver
1010

1111
spring.flyway.enabled=true
12-
spring.flyway.url=jdbc:postgresql://localhost:5432/todo_db
12+
spring.flyway.url=jdbc:postgresql://postgres_db:5440/todo_db
1313
spring.flyway.driver-class-name=org.postgresql.Driver
1414
spring.flyway.schemas=public
1515
#spring.flyway.baseline-version=1

0 commit comments

Comments
 (0)