Merge pull request #340 from nl-portal/feature/remove-empty-dmn-rules

To avoid empty DMN rules in response

Author: flinden68

gradle.properties

@@ -5,7 +5,7 @@ dockerRegion=eu-central-1
 
 kotlinVersion=2.0.21
 springBootVersion=3.4.0
-springDependencyManagementVersion=1.1.6
+springDependencyManagementVersion=1.1.7
 benManesVersionsVersion=0.51.0
 ktlintVersion=12.1.2
 spotlessVersion=6.25.0

product/src/main/kotlin/nl/nlportal/product/service/DmnService.kt

@@ -66,7 +66,7 @@ class DmnService(
                 key,
                 variablesMapping,
             )
-        return dmnClient.getDecision(dmnRequest)
+        return filterEmptyDecisionRules(dmnClient.getDecision(dmnRequest))
     }
 
     suspend fun getDecision(
@@ -125,7 +125,7 @@ class DmnService(
                 beslisTabelConfiguration.key,
                 variablesMapping,
             )
-        return dmnClient.getDecision(dmnRequest)
+        return filterEmptyDecisionRules(dmnClient.getDecision(dmnRequest))
     }
 
     suspend fun getProductDecision(
@@ -201,7 +201,11 @@ class DmnService(
                 beslisTabelConfiguration.key,
                 variablesMapping,
             )
-        return dmnClient.getDecision(dmnRequest)
+        return filterEmptyDecisionRules(dmnClient.getDecision(dmnRequest))
+    }
+
+    private fun filterEmptyDecisionRules(decisions: List<Map<String, DmnResponse>>): List<Map<String, DmnResponse>> {
+        return decisions.filter { it.isNotEmpty() }
     }
 
     private fun findBeslisTabelConfiguration(

product/src/test/resources/product/data/get-dmn-decision.json

@@ -49,5 +49,6 @@
       "value": "LINK",
       "valueInfo": {}
     }
-  }
+  },
+  {}
 ]