Refactor generalize points #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuhoErvasti
requested changes
Oct 16, 2025
Collaborator
There was a problem hiding this comment.
I think the same comments from #22 apply here, so
- CLI command
@overridedecoratorgpd.GeoDataFrame->GeoDataFrameetc.reference_data: dict[str, gpd.GeoDataFrame] | None = None,this type annotation
nmaarnio
force-pushed
the
refactor-generalize-points
branch
2 times, most recently
from
76dd55f to
39478cf
Compare
nmaarnio
force-pushed
the
refactor-generalize-points
branch
from
39478cf to
1daf0b0
Compare
nmaarnio
force-pushed
the
refactor-generalize-points
branch
2 times, most recently
from
0733f55 to
9906552
Compare
JuhoErvasti
approved these changes
Nov 6, 2025
Collaborator
There was a problem hiding this comment.
Looks good, I think we can merge at this point but for future reference I think unique_key_column needs to be dropped as a member and reduce_nearby_points_by_clustering should be refactored to use the gdf's index. Also as far as I can tell the cluster_members_column column will persist in the output data which would be unwanted, but since (I think) it's related to the id handling it can probably be handled later?
Collaborator
Author
|
Yeah, I think those changes can be implemented later. |
Added input geometry type check, changed execute to _execute, added alg class documentation, changed import style in module and added default parameter values.
nmaarnio
force-pushed
the
refactor-generalize-points
branch
from
9906552 to
9984360
Compare
nmaarnio
force-pushed
the
refactor-generalize-points
branch
from
9984360 to
66600b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generalize points algorithm was refactored into GeneralizePoints algorithm class that inherits BaseAlgorithm.
Changes in this PR:
ID handling will be implemented in a separate PR.
Type of change
Bug fix
New feature
Other
Non-breaking change
Breaking change
Developer checklist