feedparser - Error: The XML document could not be parsed as a feed

[My-Random-Thoughts]

Which node are you reporting and issue on?

Feedparser v1.0.5

What are the steps to reproduce?

Ingest broken feed (not sure on specifications)

I have it reading a feed every 15 minutes.

What happens?

My entire node-red instance crashes and reboots.

13 May 08:00:06 - [error] Error: The XML document could not be parsed as a feed
    at parseFeed (/data/node_modules/@rowanmanning/feed-parser/index.js:38:8)
    at getFeed (/data/node_modules/node-red-node-feedparser/32-feedparse.js:34:30)
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)

13 May 08:00:07 - [info]
Welcome to Node-RED
===================
13 May 08:00:07 - [info] Node-RED version: v4.1.10
13 May 08:00:07 - [info] Node.js  version: v22.22.2
13 May 08:00:07 - [info] Linux 6.1.0-18-amd64 x64 LE

What did you expect to happen?

Not to crash my entire node-red instance

Example flow

No response

Environment

• Node-RED : node-red-docker@4.1.10 /usr/src/node-red
• Node.js : v22.22.2
• npm : 10.9.8
• Platform : Linux 6.1.0-18-amd64 x86_64
• Browser : FireFox (150.0.2)

[dceejay]

do you have an example flow - or the feed url you are trying to read ?

[My-Random-Thoughts]

An example flow would be just the node connected to any other node (debug, or such)
The feed URL is a private tracker I use so can't be shared. Difficult I know.

I would hope that an invalid XML feed could be handled and ignored, and not crash the entire instance.
How does the XML parser node handle invalid data?

[dceejay]

Have added a try/catch around the parse - hopefully will fix it for you - v1.0.6

[My-Random-Thoughts]

Oops:

13 May 21:26:43 - [error] ReferenceError: feed is not defined
    at Timeout.getFeed [as _onTimeout] (/data/node_modules/node-red-node-feedparser/32-feedparse.js:47:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)

[dceejay]

and v1.0.7 ?

[osvedman]

This commit causes Node-RED to go into a crashloop upon startup for me in 1.0.6:

May 13 23:05:54 raspberrypi Node-RED[31823]: [red] Uncaught Exception:
May 13 23:05:54 raspberrypi Node-RED[31823]: 13 May 23:05:54 - [error] ReferenceError: feed is not defined
May 13 23:05:54 raspberrypi Node-RED[31823]:     at Timeout.getFeed [as _onTimeout] (/home/pi/.node-red/node_modules/node-red-node-feedparser/32-feedparse.js:47:37)
May 13 23:05:54 raspberrypi Node-RED[31823]:     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

[osvedman]

1.0.7 fixed the crash, thank you for the quick turnaround!

[My-Random-Thoughts]

Also confirm 1.0.7 is not crash-looping, thank you.