Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate PR for removing EOL Node.js versions #2101

Open
nschonni opened this issue Jun 5, 2024 · 2 comments
Open

Automate PR for removing EOL Node.js versions #2101

nschonni opened this issue Jun 5, 2024 · 2 comments

Comments

@nschonni
Copy link
Member

nschonni commented Jun 5, 2024

Problem

While doing #2100, I realized that our data is probably structured well enough that these PRs could be automated.

Solution

Create a (daily?) CI that:

  • Query the version.json for "end" <= Today
  • Delete the EOL node in version.json
  • Delete any version folders that are no longer in version.json
  • Create PR if there is diff

This could probably use https://github.com/nodejs/docker-node/blob/main/.github/workflows/automatic-updates.yml as an example, but probably should be it's own job.

Alternatives to Consider

This happens so infrequently that we don't want to bother automating

@LaurentGoderre
Copy link
Member

I think how infrequent and how little change it is, I would vote to not do this. It could prevent cases where the dates change last minute and aren't update here.

@SimenB
Copy link
Member

SimenB commented Jun 6, 2024

The release schedule exists as a JSON file - we should probably use data from that rather than duplicate its info into our own versions.json file.

https://github.com/nodejs/Release/blob/main/schedule.json

Then we at least won't have stale data to compare to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants