fixup!

Author: avivkeller

…t/parallel/test-cli-node-options-docs.js test/doctool/test-manpage-node-options.jstest/parallel/test-cli-node-options-docs.js renamed to test/doctool/test-manpage-node-options.js test/parallel/test-cli-node-options-docs.js renamed to test/doctool/test-manpage-node-options.js

@@ -22,13 +22,22 @@ const addOptionRE = /AddOption[\s\n\r]*\([\s\n\r]*"([^"]+)"(.*?)\);/gs;
 const nodeOptionsText = cliText.match(/<!-- node-options-node start -->(.*)<!-- node-options-others end -->/s)[1];
 const v8OptionsText = cliText.match(/<!-- v8-options start -->(.*)<!-- v8-options end -->/s)[1];
 
+const manPage = path.join(rootDir, 'out', 'doc', 'node.1');
+const manPageText = fs.readFileSync(manPage, { encoding: 'utf8' });
+
 // Documented in /doc/api/deprecations.md
 const deprecated = [
   '--debug',
   '--debug-brk',
 ];
 
 
+const manPagesOptions = new Set();
+
+for (const [, envVar] of manPageText.matchAll(/\.It Fl (-[a-zA-Z0-9._-]+)/g)) {
+  manPagesOptions.add(envVar);
+}
+
 for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
   const hasTrueAsDefaultValue = /,\s*(?:true|HAVE_[A-Z_]+)\s*$/.test(config);
   const isInNodeOption = config.includes('kAllowedInEnvvar') && !config.includes('kDisallowedInEnvvar');
@@ -41,18 +50,22 @@ for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
     isNoOp
   ) {
     // assert(!manPagesOptions.has(envVar.slice(1)), `Option ${envVar} should not be documented`)
+    manPagesOptions.delete(envVar.slice(1));
     continue;
   }
 
   // Internal API options are documented in /doc/contributing/internal-api.md
   if (new RegExp(`####.*\`${RegExp.escape(envVar)}[[=\\s\\b\`]`).test(internalApiText)) {
+    manPagesOptions.delete(envVar.slice(1));
     continue;
   }
 
   // CLI options
   if (!isV8Option && !hasTrueAsDefaultValue) {
     if (!new RegExp(`###.*\`${RegExp.escape(envVar)}[[=\\s\\b\`]`).test(cliText)) {
       assert.fail(`Should have option ${envVar} documented`);
+    } else {
+      manPagesOptions.delete(envVar.slice(1));
     }
   }
 
@@ -63,6 +76,8 @@ for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
   if (!isV8Option && hasTrueAsDefaultValue) {
     if (!new RegExp(`###.*\`--no${RegExp.escape(envVar.slice(1))}[[=\\s\\b\`]`).test(cliText)) {
       assert.fail(`Should have option --no${envVar.slice(1)} documented`);
+    } else {
+      manPagesOptions.delete(`-no${envVar.slice(1)}`);
     }
   }
 
@@ -84,6 +99,8 @@ for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
   if (isV8Option) {
     if (!new RegExp(`###.*\`${RegExp.escape(envVar)}[[=\\s\\b\`]`).test(v8OptionsText)) {
       assert.fail(`Should have option ${envVar} in V8 options documented`);
+    } else {
+      manPagesOptions.delete(envVar.slice(1));
     }
   }
 }
@@ -102,3 +119,8 @@ for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
     previousIndex = match?.index;
   } while (match);
 }
+
+// add alias handling
+manPagesOptions.delete('-trace-events-enabled');
+
+assert.strictEqual(manPagesOptions.size, 0, `Man page options not documented: ${[...manPagesOptions]}`);