test: ensure assertions are reached on more tests

PR-URL: #60500
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>

Author: aduh95

test/eslint.config_partial.mjs

@@ -191,6 +191,10 @@ export default [
         'wasm-allocation',
         'wpt',
       ].join(',')}}/**/*.{js,mjs,cjs}`,
+      `test/parallel/test-{${
+        // 0x61 is code for 'a', this generates a string enumerating latin letters: 'z*,y*,…'
+        Array.from({ length: 2 }, (_, i) => String.fromCharCode(0x61 + 25 - i, 42)).join(',')
+      }}.{js,mjs,cjs}`,
     ],
     rules: {
       'node-core/must-call-assert': 'error',

test/parallel/test-zlib-brotli-16GB.js

@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+const common = require('../common');
 
 // This test ensures that zlib throws a RangeError if the final buffer needs to
 // be larger than kMaxLength and concatenation fails.
@@ -18,9 +18,9 @@ buffer.kMaxLength = oldkMaxLength;
 const encoded = Buffer.from('G38A+CXCIrFAIAM=', 'base64');
 
 // Async
-zlib.brotliDecompress(encoded, function(err) {
+zlib.brotliDecompress(encoded, common.mustCall((err) => {
   assert.ok(err instanceof RangeError);
-});
+}));
 
 // Sync
 assert.throws(function() {

test/parallel/test-zlib-brotli-kmaxlength-rangeerror.js

@@ -47,9 +47,7 @@ const pmmResultBuffers = [];
 
 fs.createReadStream(pmmFileGz)
   .pipe(zlib.createGunzip())
-  .on('error', (err) => {
-    assert.ifError(err);
-  })
+  .on('error', common.mustNotCall())
   .on('data', (data) => pmmResultBuffers.push(data))
   .on('finish', common.mustCall(() => {
     // Result should match original random garbage
@@ -61,9 +59,7 @@ fs.createReadStream(pmmFileGz)
   const resultBuffers = [];
 
   const unzip = zlib.createGunzip()
-    .on('error', (err) => {
-      assert.ifError(err);
-    })
+    .on('error', common.mustNotCall())
     .on('data', (data) => resultBuffers.push(data))
     .on('finish', common.mustCall(() => {
       assert.strictEqual(

test/parallel/test-zlib-from-concatenated-gzip.js

@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+const common = require('../common');
 
 // This test ensures that zlib throws a RangeError if the final buffer needs to
 // be larger than kMaxLength and concatenation fails.
@@ -18,9 +18,9 @@ buffer.kMaxLength = oldkMaxLength;
 const encoded = Buffer.from('H4sIAAAAAAAAA0tMHFgAAIw2K/GAAAAA', 'base64');
 
 // Async
-zlib.gunzip(encoded, function(err) {
+zlib.gunzip(encoded, common.mustCall((err) => {
   assert.ok(err instanceof RangeError);
-});
+}));
 
 // Sync
 assert.throws(function() {

test/parallel/test-zlib-kmaxlength-rangeerror.js

@@ -17,9 +17,7 @@ assert.throws(function() {
 }, RangeError);
 
 // Async
-zlib.brotliDecompress(encoded, { maxOutputLength: 256 }, function(err) {
-  assert.strictEqual(err, null);
-});
+zlib.brotliDecompress(encoded, { maxOutputLength: 256 }, common.mustSucceed());
 
 // Sync
 zlib.brotliDecompressSync(encoded, { maxOutputLength: 256 });

test/parallel/test-zlib-maxOutputLength.js

@@ -21,9 +21,7 @@ for (const fn of [
 
   const output = [];
   inflate
-    .on('error', (err) => {
-      assert.ifError(err);
-    })
+    .on('error', common.mustNotCall())
     .on('data', (chunk) => output.push(chunk))
     .on('end', common.mustCall(
       () => assert.strictEqual(Buffer.concat(output).toString(), 'abc')));

test/parallel/test-zlib-reset-before-write.js

@@ -1,7 +1,7 @@
 'use strict';
 // Tests zlib streams with truncated compressed input
 
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const zlib = require('zlib');
 
@@ -23,8 +23,7 @@ const errMessage = /unexpected end of file/;
   { comp: 'deflate', decomp: 'inflate', decompSync: 'inflateSync' },
   { comp: 'deflateRaw', decomp: 'inflateRaw', decompSync: 'inflateRawSync' },
 ].forEach(function(methods) {
-  zlib[methods.comp](inputString, function(err, compressed) {
-    assert.ifError(err);
+  zlib[methods.comp](inputString, common.mustSucceed((compressed) => {
     const truncated = compressed.slice(0, compressed.length / 2);
     const toUTF8 = (buffer) => buffer.toString('utf-8');
 
@@ -33,20 +32,19 @@ const errMessage = /unexpected end of file/;
     assert.strictEqual(toUTF8(decompressed), inputString);
 
     // async sanity
-    zlib[methods.decomp](compressed, function(err, result) {
-      assert.ifError(err);
+    zlib[methods.decomp](compressed, common.mustSucceed((result) => {
       assert.strictEqual(toUTF8(result), inputString);
-    });
+    }));
 
     // Sync truncated input test
     assert.throws(function() {
       zlib[methods.decompSync](truncated);
     }, errMessage);
 
     // Async truncated input test
-    zlib[methods.decomp](truncated, function(err, result) {
+    zlib[methods.decomp](truncated, common.mustCall((err) => {
       assert.match(err.message, errMessage);
-    });
+    }));
 
     const syncFlushOpt = { finishFlush: zlib.constants.Z_SYNC_FLUSH };
 
@@ -55,10 +53,9 @@ const errMessage = /unexpected end of file/;
     assert.strictEqual(result, inputString.slice(0, result.length));
 
     // Async truncated input test, finishFlush = Z_SYNC_FLUSH
-    zlib[methods.decomp](truncated, syncFlushOpt, function(err, decompressed) {
-      assert.ifError(err);
+    zlib[methods.decomp](truncated, syncFlushOpt, common.mustSucceed((decompressed) => {
       const result = toUTF8(decompressed);
       assert.strictEqual(result, inputString.slice(0, result.length));
-    });
-  });
+    }));
+  }));
 });

test/parallel/test-zlib-truncated.js

@@ -1,31 +1,21 @@
 'use strict';
 require('../common');
-const assert = require('assert').strict;
+const assert = require('assert');
 const test = require('node:test');
 const { DecompressionStream } = require('stream/web');
 
-async function expectTypeError(promise) {
-  let threw = false;
-  try {
-    await promise;
-  } catch (err) {
-    threw = true;
-    assert(err instanceof TypeError, `Expected TypeError, got ${err}`);
-  }
-  assert(threw, 'Expected promise to reject');
-}
-
 test('DecompressStream deflat emits error on trailing data', async () => {
   const valid = new Uint8Array([120, 156, 75, 4, 0, 0, 98, 0, 98]); // deflate('a')
   const empty = new Uint8Array(1);
   const invalid = new Uint8Array([...valid, ...empty]);
   const double = new Uint8Array([...valid, ...valid]);
 
   for (const chunk of [[invalid], [valid, empty], [valid, valid], [valid, double]]) {
-    await expectTypeError(
+    await assert.rejects(
       Array.fromAsync(
         new Blob([chunk]).stream().pipeThrough(new DecompressionStream('deflate'))
-      )
+      ),
+      { name: 'TypeError' },
     );
   }
 });
@@ -37,10 +27,11 @@ test('DecompressStream gzip emits error on trailing data', async () => {
   const invalid = new Uint8Array([...valid, ...empty]);
   const double = new Uint8Array([...valid, ...valid]);
   for (const chunk of [[invalid], [valid, empty], [valid, valid], [double]]) {
-    await expectTypeError(
+    await assert.rejects(
       Array.fromAsync(
         new Blob([chunk]).stream().pipeThrough(new DecompressionStream('gzip'))
-      )
+      ),
+      { name: 'TypeError' },
     );
   }
 });

test/parallel/test-zlib-type-error.js

@@ -1,38 +1,30 @@
 'use strict';
 
-require('../common');
+const common = require('../common');
 
 const assert = require('node:assert');
 const zlib = require('node:zlib');
-const { test } = require('node:test');
 
-test('zlib should unzip one byte chunks', async () => {
-  const { promise, resolve } = Promise.withResolvers();
-  const data = Buffer.concat([
-    zlib.gzipSync('abc'),
-    zlib.gzipSync('def'),
-  ]);
+const data = Buffer.concat([
+  zlib.gzipSync('abc'),
+  zlib.gzipSync('def'),
+]);
 
-  const resultBuffers = [];
+const resultBuffers = [];
 
-  const unzip = zlib.createUnzip()
-    .on('error', (err) => {
-      assert.ifError(err);
-    })
-    .on('data', (data) => resultBuffers.push(data))
-    .on('finish', () => {
-      const unzipped = Buffer.concat(resultBuffers).toString();
-      assert.strictEqual(unzipped, 'abcdef',
-                         `'${unzipped}' should match 'abcdef' after zipping ` +
-        'and unzipping');
-      resolve();
-    });
+const unzip = zlib.createUnzip()
+  .on('error', common.mustNotCall())
+  .on('data', (data) => resultBuffers.push(data))
+  .on('finish', common.mustCall(() => {
+    const unzipped = Buffer.concat(resultBuffers).toString();
+    assert.strictEqual(unzipped, 'abcdef',
+                       `'${unzipped}' should match 'abcdef' after zipping ` +
+      'and unzipping');
+  }));
 
-  for (let i = 0; i < data.length; i++) {
-    // Write each single byte individually.
-    unzip.write(Buffer.from([data[i]]));
-  }
+for (let i = 0; i < data.length; i++) {
+  // Write each single byte individually.
+  unzip.write(Buffer.from([data[i]]));
+}
 
-  unzip.end();
-  await promise;
-});
+unzip.end();