Skip to content

Commit 29b14f7

Browse files
committed
bugfixes, version bumped
1 parent 7273295 commit 29b14f7

File tree

3 files changed

+58
-15
lines changed

3 files changed

+58
-15
lines changed

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.1.0-dev
1+
0.1.0

semver.sh

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,6 @@ resolve_rule()
184184
# Tilde
185185
elif regex_match "$1" "~$RE_VER"; then
186186
echo "tilde $MATCHED_VER_1"
187-
elif regex_match "$1" "$RE_NUM(\.[x*])+"; then
188-
echo "tilde $MATCHED_NUM_1"
189187

190188
# Caret
191189
elif regex_match "$1" "\^$RE_VER"; then
@@ -262,23 +260,28 @@ rule_ge_le()
262260

263261
rule_tilde()
264262
{
265-
ver1=$(get_version "$1")
266-
maj2=$(get_major "$2")
267-
min2=$(get_minor "$2")
263+
num=$(get_version "$1")
264+
maj=$(get_major "$1")
265+
min=$(get_minor "$1")
268266

269-
if semver_ge "$3" "$maj2"".$min2"".0-0" && semver_le; then
267+
if semver_ge "$2" "$num-0" && semver_le "$2" "$maj"".$(( $min + 1 )).0-0"; then
270268
return 0
271269
else
272270
return 1
273271
fi
274272
}
273+
if [ $# -eq 0 ]; then
274+
echo "Usage: $0 -r <rule> <version> [<version>... ]"
275+
fi
275276

276-
while getopts r: o; do
277+
while getopts r:h o; do
277278
case "$o" in
278-
r) rule="rule_$(resolve_rule $OPTARG)";;
279+
r) rule="rule_$(resolve_rule "$OPTARG")";;
280+
h|?) echo "Usage: $0 -r <rule> <version> [<version>... ]"
279281
esac
280282
done
281283

284+
282285
shift $(( $OPTIND-1 ))
283286

284287
for ver in $@; do

tests.sh

Lines changed: 46 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -176,11 +176,11 @@ describe 'reslove_rule'
176176
RET=$(resolve_rule '~1.2.3')
177177
assert "$RET" "tilde 1.2.3" "Tilde (~1.2.3)"
178178

179-
RET=$(resolve_rule '1.2.x')
180-
assert "$RET" "tilde 1.2" "Wildcard (1.2.x)"
179+
#RET=$(resolve_rule '1.2.x')
180+
#assert "$RET" "tilde 1.2" "Wildcard (1.2.x)"
181181

182-
RET=$(resolve_rule '1.*')
183-
assert "$RET" "tilde 1" "Wildcard (1.*)"
182+
#RET=$(resolve_rule '1.*')
183+
#assert "$RET" "tilde 1" "Wildcard (1.*)"
184184

185185
RET=$(resolve_rule '^1.2.3')
186186
assert "$RET" "caret 1.2.3" "Caret (^1.2.3)"
@@ -195,14 +195,54 @@ describe "rule_eq"
195195
rule_eq '1.2.3-a' '1.2.3-b'
196196
assert $? 1
197197

198+
describe "rule_gt_lt"
199+
rule_gt_lt '1.2.3' '2.3.4' '1.2.3'
200+
assert $? 1
201+
202+
rule_gt_lt '1.2.3' '2.3.4' '2.1.0'
203+
assert $? 0
204+
205+
rule_gt_lt '1.2.3' '2.3.4' '2.3.4'
206+
assert $? 1
207+
208+
describe "rule_gt_le"
209+
rule_gt_le '1.2.3' '2.3.4' '1.2.3'
210+
assert $? 1
211+
212+
rule_gt_le '1.2.3' '2.3.4' '2.1.0'
213+
assert $? 0
214+
215+
rule_gt_le '1.2.3' '2.3.4' '2.3.4'
216+
assert $? 0
217+
218+
describe "rule_ge_lt"
219+
rule_ge_lt '1.2.3' '2.3.4' '1.2.3'
220+
assert $? 0
221+
222+
rule_ge_lt '1.2.3' '2.3.4' '2.1.0'
223+
assert $? 0
224+
225+
rule_ge_lt '1.2.3' '2.3.4' '2.3.4'
226+
assert $? 1
227+
228+
describe "rule_ge_le"
229+
rule_ge_le '1.2.3' '2.3.4' '1.2.3'
230+
assert $? 0
231+
232+
rule_ge_le '1.2.3' '2.3.4' '2.1.0'
233+
assert $? 0
234+
235+
rule_ge_le '1.2.3' '2.3.4' '2.3.4'
236+
assert $? 0
237+
198238
describe "rule_tilde"
199239
rule_tilde '1.2.3' '1.2.2'
200240
assert $? 1
201241

202-
rule_tilde '1.2.3' '1.2.3-0'
242+
rule_tilde '1.2.3' '1.2.5'
203243
assert $? 0
204244

205-
rule_tilde '1.2.3' '1.3.0-0'
245+
rule_tilde '1.2.3' '1.3.0'
206246
assert $? 1
207247

208248

0 commit comments

Comments
 (0)