fixed some checkout validation issues

Author: jamesbramich

view/frontend/web/css/nofrixion-styles.css

@@ -96,5 +96,7 @@
 }
 
 #processing-animation {
-	text-align: center; margin: 8rem;
+	text-align: center; 
+  margin: 4rem;
+  height: 40%;
 }

view/frontend/web/js/view/payment/method-renderer/nofrixion-bank.js

@@ -3,15 +3,13 @@ define(
         'jquery',
         'ko',
         'Magento_Customer/js/model/customer',
-        'Magento_Ui/js/model/messages',
         'Magento_Checkout/js/view/payment/default'
     ],
-    function ($, ko, Customer, Messages, Component) {
+    function ($, ko, customer, Component) {
         'use strict';
         var self;
         var baseRedirectUrl = window.checkoutConfig.payment.nofrixion.paymentRedirectUrl;
         var payByBankProviderId = '';
-        //var buttonClicked = ko.observable(false);
         return Component.extend({
             defaults: {
                 template: 'Nofrixion_Payments/payment/nofrixion-bank'
@@ -22,17 +20,19 @@ define(
                 self = this;
                 self.payByBankProviders = window.checkoutConfig.payment.nofrixion.payByBankProviders;
             },
+            isCustomerLoggedIn: customer.isLoggedIn,
+            isProcessing: ko.observable(false),
+            redirectAfterPlaceOrder: false,
             initiatePayment: function (data, event) {
                 payByBankProviderId = data.personalInstitutionID;
-                self.isProcessing(true);
-                self.placeOrder(data, event);
+                if (self.placeOrder(data, event)) {
+                    // placeOrder returns true if form validates
+                    self.isProcessing(true);
+                };
             },
             getPayByBankProviders: function () {
                 return self.payByBankProviders;
             },
-            isCustomerLoggedIn: Customer.isLoggedIn,
-            isProcessing: ko.observable(false),
-            redirectAfterPlaceOrder: false,
             afterPlaceOrder: function () {
                 var url = baseRedirectUrl + '?bankId=' + encodeURIComponent(payByBankProviderId);
                 console.log('Redirecting to : ' + url);

view/frontend/web/template/payment/nofrixion-bank.html

@@ -31,6 +31,7 @@
         <!-- /ko -->
         <!--/ko-->
         <div id="payment-blocks" data-bind="hidden: isProcessing()">
+            
             <div class="nofrixion-payment-section nofrixion-email-warning"
                 data-bind="visible: !isPlaceOrderActionAllowed()">
                 Email and billing address are required before proceeding with payment.
@@ -54,7 +55,9 @@
                 <div class="nofrixion-login-prompt" data-bind="hidden: isCustomerLoggedIn">
                     <p><strong>You are NOT logged in.</strong></p>
                     <p>Registering an account and signing in improves the chance of your cart being restored if
-                        your financial institution has difficulties processing the payment.</p>
+                        your financial institution has difficulties processing the payment. <a class="action action-register action-help" data-bind="attr: {href: window.checkoutConfig.registerUrl}">
+                            <span data-bind="i18n: 'Create an account.'"></span>
+                        </a></p>
                 </div>
             </div>