Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Update Model and Config Repository Links (if possible) #184

Open
Bebra777228 opened this issue Feb 22, 2025 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@Bebra777228
Copy link
Contributor

Description

Recently, I created two repositories for UVR configs and models:

In the second link, you can find two files: model_list_filenames.json and model_list_links.json

  • The first file contains user-friendly model names and model filenames.
  • The second file contains the same information but with links to the provided models and configs.
    • Models are sourced from my HuggingFace repository.
    • Configs are sourced from my GitHub repository.

I think this will make it much easier to edit configs and add new models.

Do you think it's possible to replace the old links with the current ones?
I haven't tried it myself yet, but I think it's a good idea since the old repository is rarely updated and doesn't add many new models. It would be better if you could add support for files from my repository. And yes, almost all the models there work fine, except those that require changes in the files bs_roformer.py and mel_band_roformer.py and the addition of new architectures.

@Bebra777228 Bebra777228 added the enhancement New feature or request label Feb 22, 2025
@beveradb
Copy link
Collaborator

Hey, I appreciate the desire to make it easier to add new models - I would like to make that easier too, without me personally being a bottleneck (especially when I'm busy or AFK for a while!)

However I'm not sure I understand the benefit of adding an external repository into the mix - in my opinion, it would be cleaner to keep everything contained within this git repo, which it already is right now (all models and configs from UVR are mirrored here: https://github.com/nomadkaraoke/python-audio-separator/releases/tag/model-configs )

I've actually got a script which makes it real easy to upload new files to that "Models & Configs" release too, here: https://github.com/nomadkaraoke/python-audio-separator/blob/main/tools/sync-to-github.py

That's what I used just now when I added the models from PR #177 an hour or so ago - I just downloaded all the models from the link provided to a local folder and ran my sync-to-github.py script to upload them to github.

The only thing stopping you from doing the same to upload new models & configs to this repo is access permissions; if I add you as a maintainer of this repo, would that work for you? Then you won't have to wait for me in order to add new models to audio-separator 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants