fix builds without guest module

The guest module requires the customisations.json with certain settings.
The previous condition did not properly remove the file when the guest
module was not included in the build.
This updated condition actively removes the file and updates the
Dockerfile to not fail when it does not exist.

Signed-off-by: Kim Brose <[email protected]>

Author: HarHarLinks

.github/workflows/element-with-modules.yml

@@ -332,7 +332,7 @@ jobs:
       - name: Collect module source files
         run: |
           mv ../build_config.yaml e2e/src/deploy/elementWeb/
-          mv ../customisations.json e2e/src/deploy/elementWeb/ || ${{ matrix.guest == 'none' }}
+          if ${{ matrix.guest == 'none' }}; then rm e2e/src/deploy/elementWeb/customisations.json; else mv ../customisations.json e2e/src/deploy/elementWeb/; fi
           mv ../nordeck-element-web-guest-module.tgz e2e/src/deploy/elementWeb/ || ${{ startsWith(matrix.guest, '@nordeck') || startsWith(matrix.guest, 'none') }}
           mv ../nordeck-element-web-opendesk-module.tgz e2e/src/deploy/elementWeb/ || ${{ startsWith(matrix.opendesk, '@nordeck') || startsWith(matrix.opendesk, 'none') }}
           mv ../nordeck-element-web-widget-lifecycle-module.tgz e2e/src/deploy/elementWeb/ || ${{ startsWith(matrix.lifecycle, '@nordeck') || startsWith(matrix.lifecycle, 'none') }}

e2e/src/deploy/elementWeb/Dockerfile

@@ -16,7 +16,8 @@ RUN yarn --network-timeout=200000 install
 # Add all configurations
 COPY /*.tgz /src/
 COPY /build_config.yaml /src
-COPY /customisations.json /src
+# COPY if exists (https://stackoverflow.com/a/70096420)
+COPY /customisations.jso[n] /src
 
 # Build Element
 RUN bash /src/scripts/docker-package.sh