Skip to content

Commit 6705723

Browse files
authored
Merge pull request #144 from bastienu/master
Add channel_for_external_user_ids option in NotificationResolver.
2 parents a7cac9a + 0d5326d commit 6705723

File tree

4 files changed

+7
-0
lines changed

4 files changed

+7
-0
lines changed

src/Resolver/NotificationResolver.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,9 @@ public function resolve(array $data): array
6565
->setAllowedTypes('include_android_reg_ids', 'array')
6666
->setDefined('include_external_user_ids')
6767
->setAllowedTypes('include_external_user_ids', 'array')
68+
->setDefined('channel_for_external_user_ids')
69+
->setAllowedTypes('channel_for_external_user_ids', 'string')
70+
->setAllowedValues('channel_for_external_user_ids', ['push', 'email'])
6871
->setDefined('include_email_tokens')
6972
->setAllowedTypes('include_email_tokens', 'array')
7073
->setDefined('include_wp_uris')

tests/Fixtures/notifications_get_all.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
"id": "e664a747-324c-406a-bafb-ab51db71c960",
5454
"include_player_ids": null,
5555
"include_external_user_ids": null,
56+
"channel_for_external_user_ids": "push",
5657
"included_segments": ["All"],
5758
"thread_id": null,
5859
"ios_badgeCount": 1,

tests/NotificationsTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ public function testGetAll(): void
128128
'id' => 'e664a747-324c-406a-bafb-ab51db71c960',
129129
'include_player_ids' => null,
130130
'include_external_user_ids' => null,
131+
'channel_for_external_user_ids' => 'push',
131132
'included_segments' => ['All'],
132133
'thread_id' => null,
133134
'ios_badgeCount' => 1,

tests/Resolver/NotificationResolverTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ public function testResolveWithValidValues(): void
4848
'include_ios_tokens' => ['value'],
4949
'include_android_reg_ids' => ['value'],
5050
'include_external_user_ids' => ['value'],
51+
'channel_for_external_user_ids' => 'push',
5152
'include_email_tokens' => ['value'],
5253
'include_wp_uris' => ['value'],
5354
'include_wp_wns_uris' => ['value'],
@@ -150,6 +151,7 @@ public function wrongValueTypesProvider(): iterable
150151
yield [['include_ios_tokens' => 'wrongType']];
151152
yield [['include_android_reg_ids' => 666]];
152153
yield [['include_external_user_ids' => 666]];
154+
yield [['channel_for_external_user_ids' => 'wrongChannel']];
153155
yield [['include_email_tokens' => 666]];
154156
yield [['include_wp_uris' => 666]];
155157
yield [['include_wp_wns_uris' => 666]];

0 commit comments

Comments
 (0)