Skip to content

Commit 69f7654

Browse files
victor-pilottonorkunas
authored andcommitted
Add missing external_user_id option to DeviceResolver (#110)
* Add missing `external_user_id` option to DeviceResolver * Add missing `external_user_id` option to DeviceResolver
1 parent c5a5f59 commit 69f7654

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

src/Resolver/DeviceResolver.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ public function resolve(array $data)
7575
->setAllowedTypes('lat', 'double')
7676
->setDefined('country')
7777
->setAllowedTypes('country', 'string')
78+
->setDefined('external_user_id')
79+
->setAllowedTypes('external_user_id', 'string')
7880
->setDefault('app_id', $this->config->getApplicationId())
7981
->setAllowedTypes('app_id', 'string');
8082

tests/OneSignal/Tests/Resolver/DeviceResolverTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public function testResolveWithValidValues()
4444
'long' => 55.1684595,
4545
'lat' => 22.7624291,
4646
'country' => 'LT',
47+
'external_user_id' => 'value',
4748
'app_id' => 'value',
4849
];
4950

@@ -109,6 +110,7 @@ public function wrongValueTypesProvider()
109110
[['country' => false]],
110111
[['app_id' => 666]],
111112
[['device_type' => 666]],
113+
[['external_user_id' => 666]],
112114
];
113115
}
114116

0 commit comments

Comments
 (0)