Skip to content

Commit 6b3f6dd

Browse files
committed
Backport all new options from v1 (#36)
* Backport all new options from v1
1 parent b9c27a3 commit 6b3f6dd

File tree

4 files changed

+54
-11
lines changed

4 files changed

+54
-11
lines changed

src/Apps.php

Lines changed: 42 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,48 @@ protected function resolve(array $data)
104104
{
105105
$resolver = new OptionsResolver();
106106

107-
$resolver->setRequired('name');
108-
$resolver->setAllowedTypes('name', 'string');
109-
$resolver->setDefined(['apns_env', 'apns_p12', 'apns_p12_password', 'gcm_key']);
110-
$resolver->setAllowedTypes('apns_env', 'string');
111-
$resolver->setAllowedValues('apns_env', ['sandbox', 'production']);
112-
$resolver->setAllowedTypes('apns_p12', 'string');
113-
$resolver->setAllowedTypes('apns_p12_password', 'string');
114-
$resolver->setAllowedTypes('gcm_key', 'string');
107+
$resolver
108+
->setRequired('name')
109+
->setAllowedTypes('name', 'string')
110+
->setDefined('apns_env')
111+
->setAllowedTypes('apns_env', 'string')
112+
->setAllowedValues('apns_env', ['sandbox', 'production'])
113+
->setDefined('apns_p12')
114+
->setAllowedTypes('apns_p12', 'string')
115+
->setDefined('apns_p12_password')
116+
->setAllowedTypes('apns_p12_password', 'string')
117+
->setDefined('gcm_key')
118+
->setAllowedTypes('gcm_key', 'string')
119+
->setDefined('chrome_key')
120+
->setAllowedTypes('chrome_key', 'string')
121+
->setDefined('safari_apns_p12')
122+
->setAllowedTypes('safari_apns_p12', 'string')
123+
->setDefined('chrome_web_key')
124+
->setAllowedTypes('chrome_web_key', 'string')
125+
->setDefined('safari_apns_p12_password')
126+
->setAllowedTypes('safari_apns_p12_password', 'string')
127+
->setDefined('site_name')
128+
->setAllowedTypes('site_name', 'string')
129+
->setDefined('safari_site_origin')
130+
->setAllowedTypes('safari_site_origin', 'string')
131+
->setDefined('safari_icon_16_16')
132+
->setAllowedTypes('safari_icon_16_16', 'string')
133+
->setDefined('safari_icon_32_32')
134+
->setAllowedTypes('safari_icon_32_32', 'string')
135+
->setDefined('safari_icon_64_64')
136+
->setAllowedTypes('safari_icon_64_64', 'string')
137+
->setDefined('safari_icon_128_128')
138+
->setAllowedTypes('safari_icon_128_128', 'string')
139+
->setDefined('safari_icon_256_256')
140+
->setAllowedTypes('safari_icon_256_256', 'string')
141+
->setDefined('chrome_web_origin')
142+
->setAllowedTypes('chrome_web_origin', 'string')
143+
->setDefined('chrome_web_gcm_sender_id')
144+
->setAllowedTypes('chrome_web_gcm_sender_id', 'string')
145+
->setDefined('chrome_web_default_notification_icon')
146+
->setAllowedTypes('chrome_web_default_notification_icon', 'string')
147+
->setDefined('chrome_web_sub_domain')
148+
->setAllowedTypes('chrome_web_sub_domain', 'string');
115149

116150
return $resolver->resolve($data);
117151
}

src/Devices.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,18 @@
66

77
class Devices
88
{
9-
const DEVICES_LIMIT = 50;
9+
const DEVICES_LIMIT = 300;
1010

1111
const IOS = 0;
1212
const ANDROID = 1;
1313
const AMAZON = 2;
1414
const WINDOWS_PHONE = 3;
15+
const WINDOWS_PHONE_MPNS = 3;
16+
const CHROME_APP = 4;
17+
const CHROME_WEB = 5;
18+
const WINDOWS_PHONE_WNS = 6;
19+
const SAFARI = 7;
20+
const FIREFOX = 8;
1521

1622
/**
1723
* @var OneSignal
@@ -267,6 +273,9 @@ protected function resolve(array $data, callable $callback = null)
267273
->setAllowedTypes('badge_count', 'int')
268274
->setDefined('last_active')
269275
->setAllowedTypes('last_active', 'int')
276+
->setDefined('test_type')
277+
->setAllowedTypes('test_type', 'int')
278+
->setAllowedValues('test_type', [1, 2])
270279
->setDefault('app_id', $this->api->getConfig()->getApplicationId());
271280

272281
return $resolver->resolve($data);

src/Notifications.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,8 @@ protected function resolve(array $data)
254254
->setAllowedTypes('chrome_big_picture', 'string')
255255
->setDefined('chrome_web_icon')
256256
->setAllowedTypes('chrome_web_icon', 'string')
257+
->setDefined('firefox_icon')
258+
->setAllowedTypes('firefox_icon', 'string')
257259
->setDefined('url')
258260
->setAllowedTypes('url', 'string')
259261
->setAllowedValues('url', function ($value) {

src/OneSignal.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,5 @@ public function __get($name)
154154
$error = 'Undefined property via __get(): %s in %s on line %u';
155155

156156
trigger_error(sprintf($error, $name, $trace[0]['file'], $trace[0]['line']), E_USER_NOTICE);
157-
158-
return;
159157
}
160158
}

0 commit comments

Comments
 (0)