Skip to content

Commit 8712a0b

Browse files
laimonasnorkunas
authored andcommitted
IOS group&collapse parameters (#115)
* IOS group&collapse parameters * Fix style issue
1 parent 5c56a6a commit 8712a0b

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

src/Resolver/NotificationResolver.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,12 @@ public function resolve(array $data)
194194
->setAllowedTypes('adm_group', 'string')
195195
->setDefined('adm_group_message')
196196
->setAllowedTypes('adm_group_message', 'array')
197+
->setDefined('thread_id')
198+
->setAllowedTypes('thread_id', 'string')
199+
->setDefined('summary_arg')
200+
->setAllowedTypes('summary_arg', 'string')
201+
->setDefined('summary_arg_count')
202+
->setAllowedTypes('summary_arg_count', 'int')
197203
->setDefined('ttl')
198204
->setAllowedTypes('ttl', 'int')
199205
->setDefined('priority')

tests/OneSignal/Tests/Resolver/NotificationResolverTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
use OneSignal\Resolver\NotificationResolver;
66
use OneSignal\Tests\ConfigMockerTrait;
77
use OneSignal\Tests\PrivateAccessorTrait;
8-
use Symfony\Component\OptionsResolver\OptionsResolver;
98
use PHPUnit\Framework\TestCase;
9+
use Symfony\Component\OptionsResolver\OptionsResolver;
1010

1111
class NotificationResolverTest extends TestCase
1212
{
@@ -103,6 +103,9 @@ public function testResolveWithValidValues()
103103
'android_group_message' => ['value'],
104104
'adm_group' => 'value',
105105
'adm_group_message' => ['value'],
106+
'thread_id' => 'value',
107+
'summary_arg' => 'value',
108+
'summary_arg_count' => 10,
106109
'ttl' => 23,
107110
'priority' => 10,
108111
'app_id' => 'value',

0 commit comments

Comments
 (0)