Add "kind" argument to notifications getAll method

Author: norkunas

composer.json

@@ -16,6 +16,7 @@
         "psr/http-client-implementation": "^1.0",
         "psr/http-factory": "^1.0",
         "psr/http-factory-implementation": "^1.0",
+        "symfony/deprecation-contracts": "^2.1",
         "symfony/options-resolver": "^3.4|^4.0|^5.0"
     },
     "require-dev": {

src/Notifications.php

@@ -39,9 +39,20 @@ public function getOne(string $id): array
      *
      * @param int $limit  How many notifications to return (max 50)
      * @param int $offset Results offset (results are sorted by ID)
+     * @param int $kind   Kind of notifications returned. Default (not set) is all notification types
      */
-    public function getAll(int $limit = null, int $offset = null): array
+    public function getAll(int $limit = null, int $offset = null/*, int $kind = null */): array
     {
+        if (func_num_args() > 2 && !is_int(func_get_arg(2))) {
+            trigger_deprecation('norkunas/onesignal-php-api', '2.1.0', 'Method %s() will have a third `int $kind` argument. Not defining it or passing a non integer value is deprecated.', __METHOD__);
+        } elseif (__CLASS__ !== static::class) {
+            $r = new \ReflectionMethod($this, __FUNCTION__);
+
+            if (\count($r->getParameters()) > 2) {
+                trigger_deprecation('norkunas/onesignal-php-api', '2.1.0', 'Method %s() will have a third `int $kind` argument. Not defining it or passing a non integer value is deprecated.', __METHOD__);
+            }
+        }
+
         $query = ['app_id' => $this->client->getConfig()->getApplicationId()];
 
         if ($limit !== null) {
@@ -52,6 +63,10 @@ public function getAll(int $limit = null, int $offset = null): array
             $query['offset'] = $offset;
         }
 
+        if (func_num_args() > 2 && is_int(func_get_arg(2))) {
+            $query['kind'] = func_get_arg(2);
+        }
+
         $request = $this->createRequest('GET', '/notifications?'.http_build_query($query));
         $request = $request->withHeader('Authorization', "Basic {$this->client->getConfig()->getApplicationAuthKey()}");