netpol name must not end with '-' (#120)

* netpol name cannot end with -
* one more redundant -

Signed-off-by: Ziv Nevo <[email protected]>

Author: zivnevo

pkg/controller/example_test.go

@@ -123,7 +123,7 @@ func ExamplePoliciesSynthesizer() {
 	//         "kind": "NetworkPolicy",
 	//         "apiVersion": "networking.k8s.io/v1",
 	//         "metadata": {
-	//             "name": "default-deny-in-namespace-",
+	//             "name": "default-deny-in-namespace",
 	//             "creationTimestamp": null
 	//         },
 	//         "spec": {

pkg/controller/synth_netpols.go

@@ -48,13 +48,17 @@ func (deployConn *deploymentConnectivity) addEgressRule(
 
 // Generate a default-deny NetworkPolicy for the given namespace
 func getNsDefaultDenyPolicy(namespace string) *network.NetworkPolicy {
+	policyName := "default-deny-in-namespace"
+	if namespace != "" {
+		policyName += "-" + namespace
+	}
 	return &network.NetworkPolicy{
 		TypeMeta: metaV1.TypeMeta{
 			Kind:       networkPolicyKind,
 			APIVersion: networkAPIVersion,
 		},
 		ObjectMeta: metaV1.ObjectMeta{
-			Name:      "default-deny-in-namespace-" + namespace,
+			Name:      policyName,
 			Namespace: namespace,
 		},
 		Spec: network.NetworkPolicySpec{

tests/bookinfo/expected_netpol_output.json

@@ -305,7 +305,7 @@
             "kind": "NetworkPolicy",
             "apiVersion": "networking.k8s.io/v1",
             "metadata": {
-                "name": "default-deny-in-namespace-",
+                "name": "default-deny-in-namespace",
                 "creationTimestamp": null
             },
             "spec": {

tests/k8s_wordpress_example/expected_netpol_output.json

@@ -105,7 +105,7 @@
             "kind": "NetworkPolicy",
             "apiVersion": "networking.k8s.io/v1",
             "metadata": {
-                "name": "default-deny-in-namespace-",
+                "name": "default-deny-in-namespace",
                 "creationTimestamp": null
             },
             "spec": {

tests/onlineboutique/expected_netpol_interface_output.json

@@ -855,7 +855,7 @@
         "kind": "NetworkPolicy",
         "apiVersion": "networking.k8s.io/v1",
         "metadata": {
-            "name": "default-deny-in-namespace-",
+            "name": "default-deny-in-namespace",
             "creationTimestamp": null
         },
         "spec": {

tests/onlineboutique/expected_netpol_output.json

@@ -859,7 +859,7 @@
             "kind": "NetworkPolicy",
             "apiVersion": "networking.k8s.io/v1",
             "metadata": {
-                "name": "default-deny-in-namespace-",
+                "name": "default-deny-in-namespace",
                 "creationTimestamp": null
             },
             "spec": {

tests/onlineboutique/expected_netpol_output.yaml

@@ -406,7 +406,7 @@ items:
       kind: NetworkPolicy
       metadata:
         creationTimestamp: null
-        name: default-deny-in-namespace-
+        name: default-deny-in-namespace
       spec:
         podSelector: {}
         policyTypes: