Skip to content

Commit 9f61786

Browse files
committed
chore(repo): add Node 24 to e2e nightly matrix
E2E nightly tests only run on Node 20 and 22. E2E nightly tests now also run on Node 24, 22, and 20 for linux. For Windows and Mac run only 24. Close NXC-3491
1 parent 6b56665 commit 9f61786

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

.github/workflows/e2e-matrix.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,20 @@ jobs:
2828
# - windows-latest Windows fails to build gradle wrapper which always runs when we build nx.
2929
## https://staging.nx.app/runs/LgD4vxGn8w?utm_source=pull-request&utm_medium=comment
3030
node_version:
31+
# TODO(v23): remove node 20 - EOL April 2026
3132
- 20
3233
- 22
33-
# - 23
34+
- 24
3435
exclude:
35-
# run just node v20 on macos and windows
36+
# run just node v24 on macos and windows
37+
- os: macos-latest
38+
node_version: 20
3639
- os: macos-latest
3740
node_version: 22
38-
# - os: macos-latest
39-
# node_version: 23
40-
# - os: windows-latest TODO (emily): Windows fails to build gradle wrapper which always runs when we build nx. Re-enable when we fix this.
41-
# node_version: 22
42-
# - os: windows-latest TODO (emily): Windows fails to build gradle wrapper which always runs when we build nx. Re-enable when we fix this.
43-
# node_version: 23
41+
# - os: windows-latest TODO(Jack): Windows fails to build gradle wrapper which always runs when we build nx. Re-enable when we fix this.
42+
# node_version: 20
43+
# - os: windows-latest TODO (Jack): Windows fails to build gradle wrapper which always runs when we build nx. Re-enable when we fix this.
44+
# node_version: 22
4445

4546
name: Cache install (${{ matrix.os }}, node v${{ matrix.node_version }})
4647
steps:

.github/workflows/nightly/process-matrix.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,19 +67,20 @@ const matrixData: MatrixData = {
6767
{ name: 'e2e-storybook', codeowners: 'S04SVQ8H0G5' },
6868
{ name: 'e2e-nuxt', codeowners: 'S04SJ6PL98X' }
6969
],
70+
// TODO(v23): remove node 20 - EOL April 2026
7071
nodeTLS: 20,
7172
setup: [
7273
{
7374
os: 'ubuntu-latest',
7475
os_name: 'Linux',
7576
os_timeout: 60,
7677
package_managers: ['npm', 'pnpm', 'yarn'],
77-
node_versions: ['20.19.0', '22.12.0'],
78+
node_versions: ['20.19.0', '22.12.0', '24.0.0'],
7879
excluded: ['e2e-detox', 'e2e-react-native', 'e2e-expo']
7980
},
80-
{ os: 'macos-latest', os_name: 'MacOS', os_timeout: 90, package_managers: ['npm'], node_versions: ['20.19.0'] }
81-
// TODO (emily): Fix Windows support as gradle fails when running nx build https://staging.nx.app/runs/LgD4vxGn8w?utm_source=pull-request&utm_medium=comment
82-
// { os: 'windows-latest', os_name: 'WinOS', os_timeout: 180, package_managers: ['npm'], node_versions: ['20.19.0'], excluded: ['e2e-detox', 'e2e-react-native', 'e2e-expo'] }
81+
{ os: 'macos-latest', os_name: 'MacOS', os_timeout: 90, package_managers: ['npm'], node_versions: ['24.0.0'] }
82+
// TODO (Jack): Fix Windows support as gradle fails when running nx build https://staging.nx.app/runs/LgD4vxGn8w?utm_source=pull-request&utm_medium=comment
83+
// { os: 'windows-latest', os_name: 'WinOS', os_timeout: 180, package_managers: ['npm'], node_versions: ['24.0.0'], excluded: ['e2e-detox', 'e2e-react-native', 'e2e-expo'] }
8384
]
8485
};
8586

0 commit comments

Comments
 (0)