fix(core): disable daemon when nx version mismatches workspace version

Add version check in DaemonClient.enabled() to ensure packages with
mismatching nx versions don't use the daemon client.

Author: FrozenPandaz

packages/nx/src/daemon/client/client.ts

@@ -25,6 +25,7 @@ import { readNxJson } from '../../config/configuration';
 import { PromisedBasedQueue } from '../../utils/promised-based-queue';
 import { DaemonSocketMessenger, Message } from './daemon-socket-messenger';
 import { getDaemonProcessIdSync, readDaemonProcessJsonCache } from '../cache';
+import { isNxVersionMismatch } from '../is-nx-version-mismatch';
 import { Hash } from '../../hasher/task-hasher';
 import { Task, TaskGraph } from '../../config/task-graph';
 import { ConfigurationSourceMaps } from '../../project-graph/utils/project-configuration-utils';
@@ -177,7 +178,9 @@ export class DaemonClient {
       // docker=true,env=false => no daemon
       // docker=true,env=true => daemon
       // WASM => no daemon because file watching does not work
+      // version mismatch => no daemon because the installed nx version differs from the running one
       if (
+        isNxVersionMismatch() ||
         ((isCI() || isDocker()) && env !== 'true') ||
         isDaemonDisabled() ||
         nxJsonIsNotPresent() ||

packages/nx/src/daemon/is-nx-version-mismatch.ts

@@ -0,0 +1,21 @@
+import { readJsonFile } from '../utils/fileutils';
+import type { PackageJson } from '../utils/package-json';
+import { nxVersion } from '../utils/versions';
+import { workspaceRoot } from '../utils/workspace-root';
+
+export function getInstalledNxVersion(): string | null {
+  try {
+    const nxPackageJsonPath = require.resolve('nx/package.json', {
+      paths: [workspaceRoot],
+    });
+    const { version } = readJsonFile<PackageJson>(nxPackageJsonPath);
+    return version;
+  } catch {
+    // node modules are absent
+    return null;
+  }
+}
+
+export function isNxVersionMismatch(): boolean {
+  return getInstalledNxVersion() !== nxVersion;
+}

packages/nx/src/daemon/server/server.ts

@@ -8,12 +8,11 @@ import {
   consumeMessagesFromSocket,
   isJsonMessage,
 } from '../../utils/consume-messages-from-socket';
-import { readJsonFile } from '../../utils/fileutils';
-import { PackageJson } from '../../utils/package-json';
 import { nxVersion } from '../../utils/versions';
 import { setupWorkspaceContext } from '../../utils/workspace-context';
 import { workspaceRoot } from '../../utils/workspace-root';
 import { getDaemonProcessIdSync, writeDaemonJsonProcessCache } from '../cache';
+import { isNxVersionMismatch } from '../is-nx-version-mismatch';
 import {
   getFullOsSocketPath,
   isWindows,
@@ -533,30 +532,14 @@ function registerProcessTerminationListeners() {
 let existingLockHash: string | undefined;
 
 function daemonIsOutdated(): string | null {
-  if (nxVersionChanged()) {
+  if (isNxVersionMismatch()) {
     return 'NX_VERSION_CHANGED';
   } else if (lockFileHashChanged()) {
     return 'LOCK_FILES_CHANGED';
   }
   return null;
 }
 
-function nxVersionChanged(): boolean {
-  return nxVersion !== getInstalledNxVersion();
-}
-
-const nxPackageJsonPath = require.resolve('nx/package.json');
-
-function getInstalledNxVersion() {
-  try {
-    const { version } = readJsonFile<PackageJson>(nxPackageJsonPath);
-    return version;
-  } catch (e) {
-    // node modules are absent, so we can return null, which would shut down the daemon
-    return null;
-  }
-}
-
 function lockFileHashChanged(): boolean {
   const lockHashes = [
     join(workspaceRoot, 'package-lock.json'),