fix(nx-dev): restore sitemap generation #35351
Merged
Merged
Conversation
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 22159d6
☁️ Nx Cloud last updated this comment at |
bcabanes
approved these changes
Apr 20, 2026
FrozenPandaz
added a commit
that referenced
this pull request
Apr 20, 2026
nx-dev sitemap generation is being restored in #35351, so the cross-site link validation branch is still needed. Keep the narrowed dependentTasksOutputFiles glob on astro-docs:validate-links — that's independent of where the nx-dev sitemap comes from.
FrozenPandaz
added a commit
that referenced
this pull request
Apr 20, 2026
validate-links reads nx-dev/nx-dev/public/sitemap-0.xml (restored by #35351) to validate cross-site links. Add nx-dev:build to dependsOn so the existing **/sitemap*.xml dependentTasksOutputFiles glob picks up nx-dev's sitemap output; before #35351 lands the existsSync guard in validate-links.ts no-ops.
barbados-clemens
approved these changes
Apr 20, 2026
…astro-docs) ## Current Behavior After the cleanup in #35315 removed next-sitemap, nx.dev/sitemap.xml and nx.dev/sitemap-0.xml 404. The framer-sitemap.ts edge function still serves /sitemap-1.xml and astro-docs serves /docs/sitemap-index.xml, but there's no root index tying them together, so SEO crawlers lose the sitemap entry point. ## Expected Behavior Bring back next-sitemap with generateRobotsTxt disabled. The sitemap target rebuilds: - public/sitemap.xml — root index (patched to include /sitemap-1.xml and /docs/sitemap-index.xml via scripts/patch-sitemap-index.mjs) - public/sitemap-0.xml — Next.js pages (now just /courses/* since the cleanup pared nx-dev down) robots.txt continues to be served via the Next.js beforeFiles rewrite to astro-docs (Content-Signal and correct sitemap URL preserved). This is a stopgap to unbreak sitemaps quickly; long-term we'll move sitemap generation out of Next.js alongside the rest of the nx-dev retirement. ## Related Issue(s) DOC-479
jaysoo
force-pushed
the
fix_nxdev_sitemap
branch
from
9e23b3a to
22159d6
Compare
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous clean-up was overly zealous and removed both
sitemap.xmlandsitemap-0.xmlbecause I assumed there was nothing from Next.js app. This restores both.A follow-up will be to move these out of Next.js, but for now the root one will point to both Framer and Next.js routes, and the latter has
/courses/*which we use still.