feat(nest): added @nx/nest/plugin with NestJS project detection through nest-cli.json#35551
Open
vrxj81 wants to merge 2 commits into
Open
feat(nest): added @nx/nest/plugin with NestJS project detection through nest-cli.json#35551vrxj81 wants to merge 2 commits into
vrxj81 wants to merge 2 commits into
Conversation
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 3053edd
☁️ Nx Cloud last updated this comment at |
Contributor
Author
Manual test steps
Resultsnx show projectsnest-testnx show project nest-test
nx build nest-test (first run)nx build nest-test (second run)nx serve nest-test |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
Since the failure was identified as flaky, the solution is to rerun CI. Because this branch comes from a fork, it is not possible for us to push directly, but you can rerun by pushing an empty commit:
git commit --allow-empty -m "chore: trigger rerun"
git push
🎓 Learn more about Self-Healing CI on nx.dev
Contributor
|
Hi @vrxj81 👋 How is this going? Do you need any help? Is it ready for review? |
Contributor
Author
hi @FrozenPandaz, |
Contributor
|
The failures seem unrelated. Please try rebasing. |
vrxj81
force-pushed
the
feat/nest-plugin-entrypoint
branch
from
899714b to
3053edd
Compare
Contributor
Author
rebased |
vrxj81
force-pushed
the
feat/nest-plugin-entrypoint
branch
from
3053edd to
12e13f5
Compare
vrxj81
force-pushed
the
feat/nest-plugin-entrypoint
branch
from
12e13f5 to
a21b384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/nestplugin does not detect NestJS projects fromnest-cli.json, so Nest applications configured that way are not picked up by the plugin.Expected Behavior
The
@nx/nestplugin detects NestJS projects throughnest-cli.json.Related Issue(s)
Refs #35503