Skip to content

chore(repo): bump workspace-plugin version and fix freebsd release#35894

Merged
FrozenPandaz merged 2 commits into
masterfrom
fix-publish-freebsd2
Jun 5, 2026
Merged

chore(repo): bump workspace-plugin version and fix freebsd release#35894
FrozenPandaz merged 2 commits into
masterfrom
fix-publish-freebsd2

Conversation

@FrozenPandaz

Copy link
Copy Markdown
Contributor

Current Behavior

The publish workflow's FreeBSD build fails computing the project graph:
Failed to load 1 Nx plugin(s) … Cannot find module @nx/js/src/utils/assets/copy-assets-handler.

tools/workspace-plugin pins @nx/js/@nx/devkit at 23.0.0-beta.4 (pre-dist-build
layout: src sources, no exports map) while the repo is on beta.22. The plugin is
type: module, so under Node ≥ 22.18 (native TS strip) its .ts loads as ESM, which
can't resolve the extensionless @nx/js/src/... import against an exports-less package.
FreeBSD CI was the first env with a ≥ 22.18 Node (pkg install node → node24).

The alpine/musl Node download URL also hardcoded the version, drifting from NODE_VERSION.

Expected Behavior

workspace-plugin resolves @nx/js through the beta.22 exports map (to dist), so the
plugin loads under native-strip ESM on any Node — FreeBSD included. CI Node is bumped to
26.3.0 and the musl download is derived from ${NODE_VERSION} so it can't drift again.

Related Issue(s)

N/A — CI fix.

tools/workspace-plugin pinned @nx/js and @nx/devkit at beta.4 (old layout, no exports map) while the repo is on beta.22. As type:module under Node >=22.18 native strip, its .ts plugin loads as ESM and cannot resolve the extensionless @nx/js/src/utils/assets/copy-assets-handler import. This surfaced on FreeBSD CI (pkg node is >=22.18). Bumping to beta.22 restores the exports map so the import resolves to dist.
…SION

Derive the unofficial-builds musl node download from ${NODE_VERSION} (already forwarded into the container via -e NODE_VERSION) so the URL cannot drift from NODE_VERSION on future bumps.
@FrozenPandaz FrozenPandaz requested a review from a team as a code owner June 5, 2026 18:36
@FrozenPandaz FrozenPandaz requested a review from MaxKless June 5, 2026 18:36
@netlify

netlify Bot commented Jun 5, 2026

Copy link
Copy Markdown

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit d3f4b54
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/6a23173b04582d0009f509a8
😎 Deploy Preview https://deploy-preview-35894--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 5, 2026

Copy link
Copy Markdown

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit d3f4b54
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/6a23173bea8c1b000874f438
😎 Deploy Preview https://deploy-preview-35894--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud

nx-cloud Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit d3f4b54

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 29m 43s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 47s View ↗
nx build workspace-plugin ✅ Succeeded 3m 34s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 15s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-06-05 19:14:20 UTC

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) June 5, 2026 18:45
@FrozenPandaz FrozenPandaz merged commit 57abbb3 into master Jun 5, 2026
26 checks passed
@FrozenPandaz FrozenPandaz deleted the fix-publish-freebsd2 branch June 5, 2026 19:15
vrxj81 pushed a commit to vrxj81/nx that referenced this pull request Jun 7, 2026
…rwl#35894)

## Current Behavior

The publish workflow's FreeBSD build fails computing the project graph:
`Failed to load 1 Nx plugin(s) … Cannot find module
@nx/js/src/utils/assets/copy-assets-handler`.

`tools/workspace-plugin` pins `@nx/js`/`@nx/devkit` at `23.0.0-beta.4`
(pre-dist-build
layout: `src` sources, no exports map) while the repo is on `beta.22`.
The plugin is
`type: module`, so under Node ≥ 22.18 (native TS strip) its `.ts` loads
as ESM, which
can't resolve the extensionless `@nx/js/src/...` import against an
exports-less package.
FreeBSD CI was the first env with a ≥ 22.18 Node (`pkg install node` →
node24).

The alpine/musl Node download URL also hardcoded the version, drifting
from `NODE_VERSION`.

  ## Expected Behavior

`workspace-plugin` resolves `@nx/js` through the beta.22 exports map (to
`dist`), so the
plugin loads under native-strip ESM on any Node — FreeBSD included. CI
Node is bumped to
26.3.0 and the musl download is derived from `${NODE_VERSION}` so it
can't drift again.

  ## Related Issue(s)

  N/A — CI fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants