Skip to content

fix(dotnet)!: graduate @nx/dotnet — drop experimental banner and the /plugin export#35895

Merged
FrozenPandaz merged 4 commits into
masterfrom
hospitable-sociology
Jun 5, 2026
Merged

fix(dotnet)!: graduate @nx/dotnet — drop experimental banner and the /plugin export#35895
FrozenPandaz merged 4 commits into
masterfrom
hospitable-sociology

Conversation

@AgentEnder

@AgentEnder AgentEnder commented Jun 5, 2026

Copy link
Copy Markdown
Member

Current Behavior

  • The @nx/dotnet plugin is labeled experimental in two user-facing places: the docs site introduction page (a caution aside) and the published npm README (generated from readme-template.md).
  • The package exposes the plugin via two specifiers: the bare @nx/dotnet and the @nx/dotnet/plugin subpath. Both resolve to the same plugin implementation, which is redundant and confusing.

Expected Behavior

  • The experimental banner/warning is removed from both the docs page and the npm README. (Factual asides — .NET SDK compatibility, minimum Nx version — are kept.)
  • The @nx/dotnet/plugin subpath export is removed. The plugin is registered solely via the bare @nx/dotnet specifier (already what nx add @nx/dotnet / the init generator writes).
  • A migration rewrites any existing nx.json plugin entries from @nx/dotnet/plugin to @nx/dotnet, handling both the string and object ({ plugin, options }) registration forms and de-duplicating if both paths are present.

Implementation notes

  • Removed the ./plugin entry from the package exports map.
  • Inlined the plugin re-export into src/index.ts, converted the internal plugin module to named exports, and deleted the now-redundant src/plugin.ts shim. The bare @nx/dotnet public surface is unchanged.
  • Added the update-23-0-0-migrate-dotnet-plugin-path migration with unit tests (6 cases, all passing).

BREAKING CHANGE: the @nx/dotnet/plugin entry point has been removed; use @nx/dotnet. The included migration updates nx.json automatically.

Related Issue(s)

N/A

- Remove the "currently experimental" aside from the .NET plugin
  introduction docs page
- Remove the matching experimental note from the published
  @nx/dotnet npm README template

The plugin is no longer experimental, so these notices no longer
reflect its status.
@AgentEnder AgentEnder requested a review from a team as a code owner June 5, 2026 18:54
@AgentEnder AgentEnder requested a review from JamesHenry June 5, 2026 18:54
@netlify

netlify Bot commented Jun 5, 2026

Copy link
Copy Markdown

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 3d62e07
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/6a233133abac0000081058e5
😎 Deploy Preview https://deploy-preview-35895--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 5, 2026

Copy link
Copy Markdown

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 3d62e07
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/6a233133fb59f0000805edc1
😎 Deploy Preview https://deploy-preview-35895--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud

nx-cloud Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 3d62e07

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 9m 30s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 56s View ↗
nx build workspace-plugin ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 17s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2026-06-05 20:41:01 UTC

- Drop the `./plugin` subpath from the package exports map; the plugin is
  now registered solely via the bare `@nx/dotnet` specifier
- Inline the plugin re-export into `index.ts`, convert the internal plugin
  module to named exports, and delete the redundant `src/plugin.ts` shim
- Add a migration that rewrites `nx.json` plugin entries from
  `@nx/dotnet/plugin` to `@nx/dotnet`

Exposing both `@nx/dotnet` and `@nx/dotnet/plugin` was redundant and
confusing since they resolved to the same plugin implementation.
Comment thread packages/dotnet/migrations.json Outdated
@AgentEnder AgentEnder changed the title docs(dotnet): drop experimental banner/warning for @nx/dotnet fix(dotnet)!: graduate @nx/dotnet — drop experimental banner and the /plugin export Jun 5, 2026
AgentEnder and others added 2 commits June 5, 2026 16:23
Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
Loop over the `nx.json` plugins array and rewrite `@nx/dotnet/plugin`
entries by index (string entries) or by mutating the object's `plugin`
property, instead of rebuilding the array. This preserves each plugin's
position, since plugin order is significant for target inference.
@FrozenPandaz FrozenPandaz merged commit 267e667 into master Jun 5, 2026
25 checks passed
@FrozenPandaz FrozenPandaz deleted the hospitable-sociology branch June 5, 2026 20:49
vrxj81 pushed a commit to vrxj81/nx that referenced this pull request Jun 7, 2026
…/plugin export (nrwl#35895)

## Current Behavior

<!-- This is the behavior we have today -->

- The `@nx/dotnet` plugin is labeled **experimental** in two user-facing
places: the docs site introduction page (a `caution` aside) and the
published npm README (generated from `readme-template.md`).
- The package exposes the plugin via **two** specifiers: the bare
`@nx/dotnet` and the `@nx/dotnet/plugin` subpath. Both resolve to the
same plugin implementation, which is redundant and confusing.

## Expected Behavior

<!-- This is the behavior we should expect with the changes in this PR
-->

- The experimental banner/warning is removed from both the docs page and
the npm README. (Factual asides — .NET SDK compatibility, minimum Nx
version — are kept.)
- The `@nx/dotnet/plugin` subpath export is removed. The plugin is
registered solely via the bare `@nx/dotnet` specifier (already what `nx
add @nx/dotnet` / the init generator writes).
- A migration rewrites any existing `nx.json` plugin entries from
`@nx/dotnet/plugin` to `@nx/dotnet`, handling both the string and object
(`{ plugin, options }`) registration forms and de-duplicating if both
paths are present.

### Implementation notes

- Removed the `./plugin` entry from the package `exports` map.
- Inlined the plugin re-export into `src/index.ts`, converted the
internal plugin module to named exports, and deleted the now-redundant
`src/plugin.ts` shim. The bare `@nx/dotnet` public surface is unchanged.
- Added the `update-23-0-0-migrate-dotnet-plugin-path` migration with
unit tests (6 cases, all passing).

**BREAKING CHANGE:** the `@nx/dotnet/plugin` entry point has been
removed; use `@nx/dotnet`. The included migration updates `nx.json`
automatically.

## Related Issue(s)

<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

N/A

---------

Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants