New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take care of C# node dockerfiles #175

Open

AnnaShaleva opened this issue May 21, 2024 · 2 comments

Labels

feature I2 S2 U2

Member

AnnaShaleva commented May 21, 2024

neo-project/neo-modules#912 is finally merged which means that https://github.com/neo-project/neo is a monorepo. We need to migrate from Dockerfile.sharp.sources.from_binaries and Dockerfile.sharp.sources.from_local_dependencies to a single Dockerfile that allows to build node from the specific revision from sources.

We also need to update Dockerfile.sharp to be able to build released monorepo version.

This issue is relevant for post-3.7.4 versions of Neo node. Depends on neo-project/neo#3232 and neo-project/neo#3244.

The text was updated successfully, but these errors were encountered:

AnnaShaleva added U2 S2 I2 feature labels

Member

roman-khimov commented May 21, 2024

We need to digest 3.7.4 first, it already changes a lot.

Member Author

AnnaShaleva commented May 21, 2024

We need to digest 3.7.4 first,

I'm in progress, this issue is for future development.

AnnaShaleva mentioned this issue

Update bench to 3.7.4 and 0.106.0 version #176

Merged

AnnaShaleva mentioned this issue

Leveldb exception handle neo-project/neo#3356

Closed

AnnaShaleva mentioned this issue

Take care of C# node build #192

Merged

4 tasks

AnnaShaleva added a commit that referenced this issue


          build: adjust C# Dockerfileis for build from sources

47e1ffa

1. Remove Dockerfile.sharp.sources.from_binaries, this way of build is not
relevant after all C# modules are moved to a single repo.
2. Rename Dockerfile.sharp.sources.from_local_dependencies to
   Dockerfile.sharp.sources, it's the only way to build C# node from
   sources.
3. Adjust sources build algorithm.
4. Adjust the related documentation.

Close #148. A part of #175.

Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva added a commit that referenced this issue


          .env: temporary switch to source-based C# node building

v3.8 of C# node is the first version that is going to have every module
in a single release build. Right now the format of release assets is not
known, hence Dockerfile.sharp is still out-of-date and will be updated
as soon as we have v3.8.0 published.

Ref. #175.

Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva added a commit that referenced this issue


          build: adjust C# Dockerfileis for build from sources

8be62b6

1. Remove Dockerfile.sharp.sources.from_binaries, this way of build is not
relevant after all C# modules are moved to a single repo.
2. Rename Dockerfile.sharp.sources.from_local_dependencies to
   Dockerfile.sharp.sources, it's the only way to build C# node from
   sources.
3. Adjust sources build algorithm.
4. Adjust the related documentation.

Close #148. A part of #175.

Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva added a commit that referenced this issue


          .env: temporary switch to source-based C# node building

6f44d28

v3.8 of C# node is the first version that is going to have every module
in a single release build. Right now the format of release assets is not
known, hence Dockerfile.sharp is still out-of-date and will be updated
as soon as we have v3.8.0 published.

Ref. #175.

Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva added a commit that referenced this issue


          build: adjust C# Dockerfileis for build from sources

bdae276

1. Remove Dockerfile.sharp.sources.from_binaries, this way of build is not
relevant after all C# modules are moved to a single repo.
2. Rename Dockerfile.sharp.sources.from_local_dependencies to
   Dockerfile.sharp.sources, it's the only way to build C# node from
   sources.
3. Adjust sources build algorithm.
4. Adjust the related documentation.

Close #148. A part of #175.

Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva added a commit that referenced this issue


          .env: temporary switch to source-based C# node building

7e0e767

v3.8 of C# node is the first version that is going to have every module
in a single release build. Right now the format of release assets is not
known, hence Dockerfile.sharp is still out-of-date and will be updated
as soon as we have v3.8.0 published.

Ref. #175.

Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva added a commit that referenced this issue


          build: adjust C# Dockerfileis for build from sources

45630a7

1. Remove Dockerfile.sharp.sources.from_binaries, this way of build is not
relevant after all C# modules are moved to a single repo.
2. Rename Dockerfile.sharp.sources.from_local_dependencies to
   Dockerfile.sharp.sources, it's the only way to build C# node from
   sources.
3. Adjust sources build algorithm.
4. Adjust the related documentation.

Close #148. A part of #175.

Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva added a commit that referenced this issue


          .env: temporary switch to source-based C# node building

2be3620

v3.8 of C# node is the first version that is going to have every module
in a single release build. Right now the format of release assets is not
known, hence Dockerfile.sharp is still out-of-date and will be updated
as soon as we have v3.8.0 published.

Ref. #175.

Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva added a commit that referenced this issue


          build: adjust C# Dockerfileis for build from sources

6540cf6

1. Remove Dockerfile.sharp.sources.from_binaries, this way of build is not
relevant after all C# modules are moved to a single repo.
2. Rename Dockerfile.sharp.sources.from_local_dependencies to
   Dockerfile.sharp.sources, it's the only way to build C# node from
   sources.
3. Adjust sources build algorithm.
4. Adjust the related documentation.

Close #148. A part of #175.

Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva added a commit that referenced this issue


          .env: temporary switch to source-based C# node building

35e8d4f

v3.8 of C# node is the first version that is going to have every module
in a single release build. Right now the format of release assets is not
known, hence Dockerfile.sharp is still out-of-date and will be updated
as soon as we have v3.8.0 published.

Ref. #175.

Signed-off-by: Anna Shaleva <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment