Skip to content

Validate (refuse) events from chain by metaservice based on current state #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
carpawell opened this issue Feb 26, 2025 · 0 comments
Closed

Validate (refuse) events from chain by metaservice based on current state #3178

carpawell opened this issue Feb 26, 2025 · 0 comments
Assignees
@carpawell
Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S2 Regular significance U2 Seriously planned
Milestone
v0.45.2

Comments

@carpawell
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when it is possible to handle events that should be blocked by design.

Describe the solution you'd like

Do not accept event that:

  1. Deletes locked objects
  2. Locks objects that do not exist
  3. Deletes objects that do not exists
  4. ...

Describe alternatives you've considered

Rely on events from FS chain. Some SNs signed it and pushed it to the contract; that means it is acceptable. @roman-khimov says it is not ok.

Additional context

#3177 (comment)
@carpawell carpawell mentioned this issue Feb 26, 2025
Merged
@roman-khimov roman-khimov added enhancement Improving existing functionality neofs-storage Storage node application issues U2 Seriously planned S2 Regular significance I4 No visible changes labels Feb 27, 2025
@roman-khimov roman-khimov mentioned this issue Feb 27, 2025
Open
@carpawell carpawell self-assigned this Mar 1, 2025
@roman-khimov roman-khimov added this to the v0.46.0 milestone Mar 3, 2025
carpawell added a commit that referenced this issue Mar 10, 2025
@carpawell
node/meta: validate objects
b6e0633 
* add new "locked by" index to raw indexes
* make MPT keys be placed only after they are put to DB (and validated)
* prohibit removal of non-existent objects
* prohibit removal of locked objects
* prohibit locking of non-existent objects

Closes #3178.

Signed-off-by: Pavel Karpy <[email protected]>
carpawell added a commit that referenced this issue Mar 11, 2025
@carpawell
node/meta: validate objects
7e918e3 
* add new "locked by" index to raw indexes
* make MPT keys be placed only after they are put to DB (and validated)
* prohibit removal of non-existent objects
* prohibit removal of locked objects
* prohibit locking of non-existent objects

Closes #3178.

Signed-off-by: Pavel Karpy <[email protected]>
carpawell added a commit that referenced this issue Mar 11, 2025
@carpawell
node/meta: validate objects
390645d 
* add new "locked by" index to raw indexes
* make MPT keys be placed only after they are put to DB (and validated)
* prohibit removal of non-existent objects
* prohibit removal of locked objects
* prohibit locking of non-existent objects

Closes #3178.

Signed-off-by: Pavel Karpy <[email protected]>
@roman-khimov roman-khimov modified the milestones: v0.46.0, v0.45.2 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S2 Regular significance U2 Seriously planned
Projects
None yet
Milestone
v0.45.2
Development

No branches or pull requests
2 participants
@roman-khimov @carpawell