Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoFS API RPC handling deadlines #3240

Open
cthulhu-rider opened this issue Mar 20, 2025 · 0 comments
Open

NeoFS API RPC handling deadlines #3240

cthulhu-rider opened this issue Mar 20, 2025 · 0 comments
Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S2 Regular significance U3 Regular

Comments

@cthulhu-rider
Copy link
Contributor

Is your feature request related to a problem? Please describe.

currently, all server API handlers rely on the context passed by the gRPC lib side (example). It may have various deadline settings:

  1. "normal", up to couple of minutes
  2. huge, e.g. >=1 hour
  3. unset, i.e. infinite context

for 1, although the "normal" concept is relative here, everything works fine. For 2, although it's finite, the handler may stuck for long time. For 3, the server hands "forever"

Describe the solution you'd like

limit request deadlines. If the deadline exceeds the limit, use the max one. For simplicity, lets have a global value for all RPCs. 1m feels good

Describe alternatives you've considered

not yet

Additional context

#3229

@cthulhu-rider cthulhu-rider added enhancement Improving existing functionality neofs-storage Storage node application issues labels Mar 20, 2025
@roman-khimov roman-khimov added U3 Regular S2 Regular significance I4 No visible changes labels Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S2 Regular significance U3 Regular
Projects
None yet
Development

No branches or pull requests

2 participants