|
| 1 | +use std::sync::Arc; |
| 2 | + |
| 3 | +use tokio::{sync::mpsc, task::JoinHandle}; |
| 4 | + |
| 5 | +use crate::modules::{ |
| 6 | + relay::cache::track_cache::TrackCache, |
| 7 | + session_event::SessionEvent, |
| 8 | + types::{SessionId, TrackKey}, |
| 9 | +}; |
| 10 | + |
| 11 | +/// Watches a track's §2.5 malformed latch and reports the detection to the |
| 12 | +/// relay event pipeline, where the upstream subscription is torn down. |
| 13 | +/// Dropped (and thereby aborted) when ingress for the track stops, so it |
| 14 | +/// never outlives the track's cache entry. |
| 15 | +pub(crate) struct MalformedTrackWatchTask { |
| 16 | + join_handle: JoinHandle<()>, |
| 17 | +} |
| 18 | + |
| 19 | +impl MalformedTrackWatchTask { |
| 20 | + pub(crate) fn run( |
| 21 | + cache: Arc<TrackCache>, |
| 22 | + track_key: TrackKey, |
| 23 | + publisher_session_id: SessionId, |
| 24 | + event_sender: mpsc::UnboundedSender<SessionEvent>, |
| 25 | + ) -> Self { |
| 26 | + let join_handle = tokio::spawn(async move { |
| 27 | + cache.malformed_track_detected().await; |
| 28 | + if event_sender |
| 29 | + .send(SessionEvent::MalformedTrackDetected( |
| 30 | + publisher_session_id, |
| 31 | + track_key.clone(), |
| 32 | + )) |
| 33 | + .is_err() |
| 34 | + { |
| 35 | + tracing::warn!(%track_key, "failed to report malformed track detection"); |
| 36 | + } |
| 37 | + }); |
| 38 | + Self { join_handle } |
| 39 | + } |
| 40 | +} |
| 41 | + |
| 42 | +impl Drop for MalformedTrackWatchTask { |
| 43 | + fn drop(&mut self) { |
| 44 | + self.join_handle.abort(); |
| 45 | + } |
| 46 | +} |
| 47 | + |
| 48 | +#[cfg(test)] |
| 49 | +mod tests { |
| 50 | + use std::time::Duration; |
| 51 | + |
| 52 | + use bytes::Bytes; |
| 53 | + use moqt::{ExtensionHeaders, SubgroupHeader, SubgroupId, SubgroupObject, SubgroupObjectField}; |
| 54 | + |
| 55 | + use super::*; |
| 56 | + use crate::modules::{core::data_object::DataObject, relay::types::StreamSubgroupId}; |
| 57 | + |
| 58 | + fn make_object(payload: &'static [u8]) -> DataObject { |
| 59 | + let message_type = |
| 60 | + SubgroupHeader::new(0, 0, SubgroupId::Value(0), 0, false, false).message_type; |
| 61 | + DataObject::SubgroupObject(SubgroupObjectField { |
| 62 | + message_type, |
| 63 | + object_id_delta: 0, |
| 64 | + extension_headers: ExtensionHeaders::default(), |
| 65 | + subgroup_object: SubgroupObject::new_payload(Bytes::from_static(payload)), |
| 66 | + }) |
| 67 | + } |
| 68 | + |
| 69 | + async fn latch_malformed(cache: &TrackCache) { |
| 70 | + let subgroup = StreamSubgroupId::Value(0); |
| 71 | + let _ = cache |
| 72 | + .append_stream_object(0, &subgroup, Some(0), make_object(b"a")) |
| 73 | + .await; |
| 74 | + let _ = cache |
| 75 | + .append_stream_object(0, &subgroup, Some(0), make_object(b"b")) |
| 76 | + .await; |
| 77 | + assert!(cache.is_malformed()); |
| 78 | + } |
| 79 | + |
| 80 | + #[tokio::test] |
| 81 | + async fn reports_detection_to_the_event_pipeline() { |
| 82 | + // Arrange |
| 83 | + let cache = Arc::new(TrackCache::new()); |
| 84 | + let track_key = TrackKey::new("ns", "track"); |
| 85 | + let (event_sender, mut event_receiver) = mpsc::unbounded_channel(); |
| 86 | + let _task = MalformedTrackWatchTask::run(cache.clone(), track_key.clone(), 7, event_sender); |
| 87 | + |
| 88 | + // Act: conflicting duplicate objects latch the track. |
| 89 | + latch_malformed(&cache).await; |
| 90 | + |
| 91 | + // Assert: the detection event names the track and its publisher session. |
| 92 | + let event = tokio::time::timeout(Duration::from_secs(3), event_receiver.recv()) |
| 93 | + .await |
| 94 | + .expect("watch task should report the detection") |
| 95 | + .expect("event channel should stay open"); |
| 96 | + match event { |
| 97 | + SessionEvent::MalformedTrackDetected(session_id, reported_track_key) => { |
| 98 | + assert_eq!(session_id, 7); |
| 99 | + assert_eq!(reported_track_key, track_key); |
| 100 | + } |
| 101 | + _ => panic!("expected MalformedTrackDetected"), |
| 102 | + } |
| 103 | + } |
| 104 | + |
| 105 | + #[tokio::test] |
| 106 | + async fn dropped_watcher_reports_nothing() { |
| 107 | + // Arrange |
| 108 | + let cache = Arc::new(TrackCache::new()); |
| 109 | + let (event_sender, mut event_receiver) = mpsc::unbounded_channel(); |
| 110 | + let task = MalformedTrackWatchTask::run( |
| 111 | + cache.clone(), |
| 112 | + TrackKey::new("ns", "track"), |
| 113 | + 7, |
| 114 | + event_sender, |
| 115 | + ); |
| 116 | + |
| 117 | + // Act: ingress stops the track before any detection. |
| 118 | + drop(task); |
| 119 | + latch_malformed(&cache).await; |
| 120 | + |
| 121 | + // Assert: the aborted watcher sends no event (sender dropped). |
| 122 | + assert!( |
| 123 | + tokio::time::timeout(Duration::from_secs(1), event_receiver.recv()) |
| 124 | + .await |
| 125 | + .expect("channel should close once the watcher is dropped") |
| 126 | + .is_none() |
| 127 | + ); |
| 128 | + } |
| 129 | +} |
0 commit comments