Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the macOS version used in GitHub Actions #674

Closed
guihkx opened this issue May 22, 2024 · 5 comments
Closed

Update the macOS version used in GitHub Actions #674

guihkx opened this issue May 22, 2024 · 5 comments

Comments

@guihkx
Copy link
Collaborator

guihkx commented May 22, 2024

I got an email from GitHub, informing me that macOS 11, which is the version we currently use to build Notes on macOS, will be removed in about a month:

image

We can probably perform a seamless upgrade to macOS 12, but testing the built binaries and also updating the documentation are a must, of course.

@nuttyartist
Copy link
Owner

Does that mean that future builds won't work on macOS 11?

@guihkx
Copy link
Collaborator Author

guihkx commented May 22, 2024

Not necessarily, I believe.

It's been a while since I built anything on macOS, but I do remember the CMAKE_OSX_DEPLOYMENT_TARGET CMake option, which we actually use to target our builds for macOS 10.15 (although Qt 6 itself doesn't support that macOS version, which makes it useless, lol).

So we can probably update the GitHub Actions runner to macOS 12, also update CMAKE_OSX_DEPLOYMENT_TARGET to 11.0, and then test the build on a macOS 11 machine.

@nuttyartist
Copy link
Owner

Haha, sounds good! I wonder how we could get our hands on a macOS 11 machine? Mine is 12. Maybe there are services for that. I've seen somewhere (mentioned in a Qt bug report) about one but forgot to save it.

@guihkx
Copy link
Collaborator Author

guihkx commented May 22, 2024

I wonder how we could get our hands on a macOS 11 machine

Wait, is it not possible to set up a virtual machine on newer macOS to use an older macOS version?

Every macOS-related work I did for Notes, was done using macOS 11 running via QEMU on Linux, so I know that's one possibility. Even though animations were very slow, since it lacked any support for GPU acceleration, it was at least "fast enough" to build, test and debug some issues...

Unfortunately, I don't have that VM set up anymore (I'm running low on disk space, lol), and I don't exactly remember how I set it up, but I probably used this amazing tool.

Though I'm afraid it's Linux-only, unfortunately.

@guihkx
Copy link
Collaborator Author

guihkx commented Jul 18, 2024

Done in #681.

@guihkx guihkx closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants