Skip to content

Enhanced API for advanced Hyperlink handling #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seflue opened this issue Apr 11, 2025 · 0 comments
Open

Enhanced API for advanced Hyperlink handling #962

seflue opened this issue Apr 11, 2025 · 0 comments
Labels
enhancement Enhancement, not necessarily available in emacs

Comments

@seflue
Copy link
Contributor

seflue commented Apr 11, 2025

Does this feature exist in Emacs orgmode core?

N/A

Orgmode link

No response

Feature value

Hi there! I wanted to share some thoughts on the hyperlink system after using it more extensively in my personal notes. I've been really impressed with how the hyperlink functionality has evolved recently, especially since I last contributed to this part of the codebase some time ago. The recent improvements to the system are a big step forward, but I've encountered some limitations when I tried to implement more advanced workflows in my personal setup. I believe that with a few small extensions to the API, these limitations could be overcome, allowing users and plugin creators to implement their own extensions to enrich link handling.

My Use Case

I'd like to customize how different types of links are handled in specific contexts. For example:

  1. Opening directory links like [[some/folder/]] in different file explorers based on context:

    • Document directories → neotree/nvim-tree/oil-buffer
    • Project directories → external file manager/new neovim-instance/vs code
  2. Adding preview capabilities to links:

    • Preview images without leaving the buffer
    • Preview org headlines before navigating to them
    • Show file metadata without opening files
    • Open-with plugin
  3. Controlling where links open:

    • Choose destination splits/windows
    • Open in background tabs

Current Limitations

I've explored the existing hyperlinks.sources configuration, which is great for adding custom link types. However, I've found some limitations:

  1. Single action per link type: The current API is focused on "following" links, but doesn't support alternative actions like "preview"

  2. Built-in handlers are fixed: Can't easily extend built-in handlers (like file:) without replacing them entirely

  3. No way to access link data: No method to get the current link's data without following it

Proposed Enhancements

I've thought about some minimal API additions that would enable these workflows without major changes:

1. Link Context Access Function

-- Get link at cursor without following it
require('orgmode').api.get_link_at_cursor()

This would return parsed link information, enabling custom keymaps like:

vim.keymap.set('n', 'K', function()
  local link = require('orgmode').api.get_link_at_cursor()
  if not link then return end
  
  -- Preview based on link type
  if link.path:match('%.png$') or link.path:match('%.jpg$') then
    require('image_preview').show(link.path)
  elseif link.type == 'headline' then
    require('headline_preview').show(link.path, link.target)
  end
end)

2. Link Follow Options

Add a minimal API method to follow links with options:

-- Follow a link with options (useful for custom keymaps)
require('orgmode').api.follow_link(link_string, {
  split = "vertical", -- or "horizontal", nil for current window
  background = false, -- true to return to current position after opening
})

-- Example custom keymap using this
vim.keymap.set('n', '<leader>ov', function()
  local link = require('orgmode').api.get_link_at_cursor()
  if link then
    require('orgmode').api.follow_link(link.raw, {split = "vertical"})
  end
end)

3. Extended File Link Handler Configuration

Enhance the existing configuration to support conditional handling:

require('orgmode').setup({
  hyperlinks = {
    file_handlers = {
      -- Pattern-based directory handling
      directories = {
        ['~/projects/.*/$'] = function(path) 
          require('neo-tree').open(path)
          return true
        end,
        ['~/documents/.*/$'] = function(path)
          vim.fn.jobstart('dolphin ' .. path, {detach = true})
          return true
        end
      },
      -- Handle specific file types differently
      files = {
        ['%.pdf$'] = function(path)
          vim.fn.jobstart('okular ' .. path, {detach = true})
          return true
        end,
        ['%.org$'] = function(path, target)
          -- Custom org file handler with window selection
          require('window_picker').pick(function(win)
            vim.api.nvim_set_current_win(win)
            -- Use the original handler to navigate to target
            require('orgmode').api.follow_file_link(path, target)
          end)
          return true
        end
      }
    }
  }
})

Benefits

These minimal changes would:

  1. Enable completely custom link workflows through regular Neovim keymaps
  2. Keep the core API simple (only 2-3 new functions)
  3. Maintain backward compatibility
  4. Allow plugins to build advanced link handling while leveraging orgmode's link parsing

@kristijanhusak What do you think of this approach? Would you be open to these types of enhancements? If so, I would be happy to contribute a PR.

Additional context

No response

@seflue seflue added the enhancement Enhancement, not necessarily available in emacs label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement, not necessarily available in emacs
Projects
None yet
Development

No branches or pull requests

1 participant