fix(helpers): fix ignore_errors override for formatters

Author: Jose Alvarez

lua/null-ls/helpers.lua

@@ -126,7 +126,7 @@ M.generator_factory = function(opts)
 end
 
 M.formatter_factory = function(opts)
-    opts.ignore_errors = true
+    if opts.ignore_errors == nil then opts.ignore_errors = true end
     opts.on_output = function(params, done)
         local output = params.output
         if not output then return done() end

test/spec/helpers_spec.lua

@@ -261,9 +261,12 @@ describe("helpers", function()
     end)
 
     describe("formatter_factory", function()
-        local opts = {key = "val"}
+        local opts
+        before_each(function()
+            stub(helpers, "generator_factory")
+            opts = {key = "val"}
+        end)
 
-        before_each(function() stub(helpers, "generator_factory") end)
         after_each(function()
             helpers.generator_factory:clear()
             helpers.generator_factory:revert()
@@ -278,6 +281,14 @@ describe("helpers", function()
             assert.truthy(helpers.generator_factory.calls[1].refs[1].on_output)
         end)
 
+        it("should not set ignore_errors when already set", function()
+            opts.ignore_errors = false
+            helpers.formatter_factory(opts)
+
+            assert.equals(helpers.generator_factory.calls[1].refs[1]
+                              .ignore_errors, false)
+        end)
+
         describe("on_output", function()
             local formatter_done = stub.new()
             after_each(function() formatter_done:clear() end)