helpers/factory: default formatter valid exit code to 0 (#221)

Co-authored-by: Zephyr Lykos <[email protected]>

Author: barrett-ruth

lua/null-ls/helpers/check_exit_code.lua

@@ -0,0 +1,27 @@
+return function(codes, silent, command)
+    local logger = require("null-ls.logger")
+
+    local check = codes
+    if type(codes) == "table" then
+        check = function(code, _)
+            return vim.tbl_contains(codes, code)
+        end
+    elseif type(codes) == "number" then
+        check = function(code, _)
+            return code <= codes
+        end
+    end
+
+    if not silent and type(check) == "function" then
+        local _check = check
+        check = function(code, stderr)
+            local result = _check(code)
+
+            if not result then
+                logger:warn(string.format("failed to run %s; see `:NullLsLog`", command))
+                logger:add_entry(string.format("failed to run %s: %s", command, stderr), "warn")
+            end
+        end
+    end
+    return check
+end

lua/null-ls/helpers/formatter_factory.lua

@@ -1,9 +1,10 @@
 return function(opts)
+    local h = require("null-ls.helpers")
+
     -- ignore errors unless otherwise specified
     if opts.ignore_stderr == nil then
         opts.ignore_stderr = true
     end
-
     -- for formatters, to_temp_file only works if from_temp_file is also set
     if opts.to_temp_file then
         opts.from_temp_file = true
@@ -18,5 +19,10 @@ return function(opts)
         return done({ { text = output } })
     end
 
-    return require("null-ls.helpers").generator_factory(opts)
+    if opts.check_exit_code == nil then
+        opts.check_exit_code = 0
+    end
+    opts.check_exit_code = h.check_exit_code(opts.check_exit_code, false, opts.command)
+
+    return h.generator_factory(opts)
 end

lua/null-ls/helpers/generator_factory.lua

@@ -132,11 +132,15 @@ return function(opts)
         opts.temp_dir,
         opts.prepend_extra_args
 
-    if type(check_exit_code) == "table" then
-        local codes = check_exit_code
+    local codes = check_exit_code
+    if type(codes) == "table" then
         check_exit_code = function(code)
             return vim.tbl_contains(codes, code)
         end
+    elseif type(codes) == "number" then
+        check_exit_code = function(code)
+            return code <= codes
+        end
     end
 
     local is_nil_table_or_func = function(v)

lua/null-ls/helpers/init.lua

@@ -1,5 +1,6 @@
 return {
     cache = require("null-ls.helpers.cache"),
+    check_exit_code = require("null-ls.helpers.check_exit_code"),
     diagnostics = require("null-ls.helpers.diagnostics"),
     formatter_factory = require("null-ls.helpers.formatter_factory"),
     generator_factory = require("null-ls.helpers.generator_factory"),