Skip to content

Commit 84d4d12

Browse files
author
Theresa
committed
Disable status bar theming in SelectableListToolbar
Nokia devices crash when trying to set to set the status bar color in bookmarks, history, and downloads. Disable status bar theming for now. BUG=880694 Change-Id: I48ae7ec0d7aa5059d70eb5a99b23e84d8263dcd0 Reviewed-on: https://chromium-review.googlesource.com/1207310 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588944}(cherry picked from commit 050fc9e) Reviewed-on: https://chromium-review.googlesource.com/1208351 Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#62} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
1 parent 1f00406 commit 84d4d12

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import android.content.res.ColorStateList;
1010
import android.graphics.Color;
1111
import android.graphics.drawable.Drawable;
12-
import android.os.Build;
1312
import android.support.annotation.CallSuper;
1413
import android.support.annotation.StringRes;
1514
import android.support.v4.view.GravityCompat;
@@ -183,9 +182,10 @@ public void initialize(SelectionDelegate<E> delegate, int titleResId,
183182
mDrawerLayout = drawerLayout;
184183
mNormalGroupResId = normalGroupResId;
185184
mSelectedGroupResId = selectedGroupResId;
186-
mUpdateStatusBarColor = updateStatusBarColor
187-
&& Build.VERSION.SDK_INT >= Build.VERSION_CODES.M
188-
&& !UiUtils.isSystemUiThemingDisabled();
185+
// TODO(twellington): Setting the status bar color crashes on Nokia devices. Re-enable
186+
// after a Nokia test device is procured and the crash can be debugged.
187+
// See https://crbug.com/880694.
188+
mUpdateStatusBarColor = false;
189189

190190
mSelectionDelegate = delegate;
191191
mSelectionDelegate.addObserver(this);

0 commit comments

Comments
 (0)