Skip to content

Commit 383a15a

Browse files
committed
CI: do not run tests nor lint nor docs-and-spec when Rust >= 1.84
It allows to still build for macos-latest on 1.84
1 parent ee9341a commit 383a15a

File tree

1 file changed

+22
-4
lines changed

1 file changed

+22
-4
lines changed

.github/workflows/ci.yml

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ jobs:
3333
ocaml_version: ${{ steps.ocaml.outputs.version }}
3434
node: ${{ steps.node.outputs.version }}
3535
matrix: ${{ steps.matrix.outputs.value }}
36+
default_rust_version: ${{ steps.defaults.outputs.rust_version }}
37+
default_os: ${{ steps.defaults.outputs.os }}
3638
steps:
3739
# FIXME: currently not available for 5.0.0.
3840
# It might be related to boxroot dependency, and we would need to bump
@@ -41,6 +43,10 @@ jobs:
4143
run: echo 'version=["4.14.2"]' >> "$GITHUB_OUTPUT"
4244
- id: node
4345
run: echo 'version=["20"]' >> "$GITHUB_OUTPUT"
46+
- id: defaults
47+
run: |
48+
echo 'rust_version=1.81' >> "$GITHUB_OUTPUT"
49+
echo 'os=ubuntu-latest' >> "$GITHUB_OUTPUT"
4450
- id: matrix
4551
run: |
4652
# NOTE: This custom matrix configuration is needed to use Rust 1.84 specifically for macOS.
@@ -92,6 +98,10 @@ jobs:
9298
rust_and_os: ${{ fromJSON(needs.define-matrix.outputs.matrix).include }}
9399
ocaml_version: ${{ fromJSON(needs.define-matrix.outputs.ocaml_version) }}
94100
node: ${{ fromJSON(needs.define-matrix.outputs.node) }}
101+
exclude:
102+
# Skip Rust 1.84 due to linting issues - remove when
103+
# https://github.com/o1-labs/proof-systems/pull/3245 is fixed
104+
- rust_and_os: {rust_toolchain_version: '1.84', os: 'macos-latest'}
95105
runs-on: ${{ matrix.rust_and_os.os }}
96106
steps:
97107
- name: Checkout repository
@@ -168,8 +178,8 @@ jobs:
168178
if: >-
169179
github.event_name == 'push' &&
170180
github.ref == 'refs/heads/master' &&
171-
matrix.rust_and_os.rust_toolchain_version == '1.81' &&
172-
matrix.rust_and_os.os == 'ubuntu-latest'
181+
matrix.rust_and_os.rust_toolchain_version == needs.define-matrix.outputs.default_rust_version &&
182+
matrix.rust_and_os.os == needs.define-matrix.outputs.default_os
173183
run: |
174184
eval $(opam env)
175185
RUSTDOCFLAGS="--enable-index-page -Zunstable-options" cargo +nightly doc --all-features --no-deps --workspace --exclude xtask
@@ -180,8 +190,8 @@ jobs:
180190
if: >-
181191
github.event_name == 'push' &&
182192
github.ref == 'refs/heads/master' &&
183-
matrix.rust_and_os.rust_toolchain_version == '1.81' &&
184-
matrix.rust_and_os.os == 'ubuntu-latest'
193+
matrix.rust_and_os.rust_toolchain_version == needs.define-matrix.outputs.default_rust_version &&
194+
matrix.rust_and_os.os == needs.define-matrix.outputs.default_os
185195
with:
186196
github_token: ${{ secrets.GITHUB_TOKEN }}
187197
publish_dir: ./book/book/html
@@ -193,6 +203,10 @@ jobs:
193203
rust_and_os: ${{ fromJSON(needs.define-matrix.outputs.matrix).include }}
194204
ocaml_version: ${{ fromJSON(needs.define-matrix.outputs.ocaml_version) }}
195205
node: ${{ fromJSON(needs.define-matrix.outputs.node) }}
206+
exclude:
207+
# Skip Rust 1.84 due to linting issues - remove when
208+
# https://github.com/o1-labs/proof-systems/pull/3245 is fixed
209+
- rust_and_os: {rust_toolchain_version: '1.84', os: 'macos-latest'}
196210
runs-on: ${{ matrix.rust_and_os.os }}
197211
steps:
198212
- name: Checkout repository
@@ -257,6 +271,10 @@ jobs:
257271
rust_and_os: ${{ fromJSON(needs.define-matrix.outputs.matrix).include }}
258272
ocaml_version: ${{ fromJSON(needs.define-matrix.outputs.ocaml_version) }}
259273
node: ${{ fromJSON(needs.define-matrix.outputs.node) }}
274+
exclude:
275+
# Skip Rust 1.84 due to linting issues - remove when
276+
# https://github.com/o1-labs/proof-systems/pull/3245 is fixed
277+
- rust_and_os: {rust_toolchain_version: '1.84', os: 'macos-latest'}
260278
runs-on: ${{ matrix.rust_and_os.os }}
261279
steps:
262280
- name: Checkout repository

0 commit comments

Comments
 (0)