Skip to content
This repository was archived by the owner on Nov 23, 2021. It is now read-only.
This repository was archived by the owner on Nov 23, 2021. It is now read-only.

Cleanup repository #1

@hohwille

Description

@hohwille

Great to see that you did a OASP4J demo in Kotlin and thanks for that. I am also looking at Kotlin with increasing interest.

However, I wanted to give some feedback for improvements:

  • you should have a .gitignore to prevent comitting generated files. See https://github.com/oasp/oasp4j/blob/develop/.gitignore
  • as you had not .gitignore in place you comitted and pushed a lot of generate stuff like .settings and especially target folders what is heavily discouraged and should be deleted.

Here is an incomplete list of such files and folders:

BTW: The recommended way is to start such repositories on https://github.com/oasp-forge/ instead of https://github.com/oasp/. oasp-forge is for experimental stuff while oasp should contain "production-ready" projects (whoever created this repo [for you]). My intention is not to blame, just to let know...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions