deployment.yaml is mutating .Values during template rendering

[sparecycles]

unset is mutating the .Values object during rendering. This makes rendering order-dependent and non-idempotent. (this is bad practice in general, as a parent chart might consider the securityContext value after .enabled is unset and make a wrong decision.)

manifests/helm/oauth2-proxy/templates/deployment.yaml

Line 102 in fe328b0

{{- $securityContext := unset .Values.initContainers.waitForRedis.securityContext "enabled" }}

and

manifests/helm/oauth2-proxy/templates/deployment.yaml

Line 336 in fe328b0

{{- $securityContext := unset .Values.securityContext "enabled" }}

Looks like this was introduced in #67

---

Suggestion, apply unset to a clone of the securityContext object, e.g.,

      {{- $securityContext := unset ( .Values.securityContext | deepCopy ) "enabled" }}