feat: removed rule that does not allow username to be user password

Author: ymarcon

agate-core/src/main/java/org/obiba/agate/domain/User.java

@@ -377,13 +377,13 @@ private Builder() {
     private Builder(String username) {
       this();
       if (!Strings.isNullOrEmpty(username)) {
+        name(username);
+        email(username);
         String uname = username;
         if (username.contains("@")) {
-          uname = username.replace("@", "_");
+          uname = username.split("@")[0];
         }
-        name(uname);
-        email(username);
-        String[] parts = uname.split("_")[0].split("\\.");
+        String[] parts = uname.split("\\.");
         if (parts.length>0)
           firstName(CaseFormat.LOWER_HYPHEN.to(CaseFormat.UPPER_CAMEL, parts[0].toLowerCase()));
         else

agate-core/src/test/java/org/obiba/agate/domain/UserTest.java

@@ -80,14 +80,14 @@ public void testBuilderFromEmail() {
     String email = "[email protected]";
     User user = User.newBuilder(email).build();
     assertEquals(email, user.getEmail());
-    assertEquals("andy.warhol_factory.org", user.getName());
+    assertEquals("andy.warhol@factory.org", user.getName());
     assertEquals("Andy", user.getFirstName());
     assertEquals("Warhol", user.getLastName());
 
     email = "[email protected]";
     user = User.newBuilder(email).build();
     assertEquals(email, user.getEmail());
-    assertEquals("andy_factory.org", user.getName());
+    assertEquals("andy@factory.org", user.getName());
     assertEquals("Andy", user.getFirstName());
     assertEquals("", user.getLastName());
   }

agate-rest/src/main/java/org/obiba/agate/web/rest/user/UsersPublicResource.java

@@ -200,15 +200,10 @@ public Response create(@Context HttpServletRequest request, MultivaluedMap<Strin
 
     String name = username == null ? null : username.trim().replaceAll(" ", "");
 
-    if (Strings.isNullOrEmpty(username)) {
+    if (Strings.isNullOrEmpty(name)) {
       if (config.isJoinWithUsername())
         throw new BadRequestException("User name cannot be empty");
-
-      try {
-        name = email.replace("@", "_");
-      } catch (Exception e) {
-        name = new ObjectId().toString();
-      }
+      name = email;
     }
 
     if (!reCaptchaService.verify(Strings.isNullOrEmpty(reCaptchaResponse) ? reCaptchaResponse2 : reCaptchaResponse))

agate-rest/src/main/java/org/obiba/agate/web/rest/user/UsersResource.java

@@ -87,9 +87,7 @@ public Agate.UserDto getUserId(@QueryParam("q") String searchTerm) {
   public Response create(Agate.UserCreateFormDto userCreateFormDto) {
     Agate.UserDto userDto = userCreateFormDto.getUser();
     String username = userDto.getName().trim();
-
-    if (new EmailValidator().isValid(username, null)) throw new BadRequestException("username can not be an email address.");
-
+    
     User user = userService.findUser(username);
 
     if(user != null) throw new BadRequestException("User already exists: " + username);