Skip to content

Commit 8b71435

Browse files
authored
fix sqlite implicit dependencies (#1910)
1 parent 4da167e commit 8b71435

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/libraries.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,7 @@ export function getImplicitDownloads(imports: Iterable<string>, duckdb?: DuckDBC
9090
}
9191
}
9292
}
93-
if (set.has("npm:@observablehq/sqlite")) {
94-
implicits.add("npm:sql.js/dist/sql-wasm.js");
93+
if (set.has("npm:sql.js")) {
9594
implicits.add("npm:sql.js/dist/sql-wasm.wasm");
9695
}
9796
if (set.has("npm:leaflet")) {
@@ -176,7 +175,9 @@ export function getImplicitDependencies(imports: Iterable<string>): Set<string>
176175
if (set.has("npm:@observablehq/duckdb")) implicits.add("npm:@duckdb/duckdb-wasm");
177176
if (set.has("npm:@observablehq/inputs")) implicits.add("npm:htl").add("npm:isoformat");
178177
if (set.has("npm:@observablehq/mermaid")) implicits.add("npm:mermaid");
178+
if (set.has("npm:@observablehq/sqlite")) implicits.add("npm:sql.js");
179179
if (set.has("npm:@observablehq/tex")) implicits.add("npm:katex");
180+
if (set.has("observablehq:stdlib/sqlite")) implicits.add("npm:sql.js");
180181
if (set.has("observablehq:stdlib/xlsx")) implicits.add("npm:exceljs");
181182
if (set.has("observablehq:stdlib/zip")) implicits.add("npm:jszip");
182183
if (set.has("observablehq:stdlib/vega-lite")) implicits.add("npm:vega-lite-api").add("npm:vega-lite").add("npm:vega");

test/libraries-test.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,7 @@ describe("getImplicitDownloads(imports)", () => {
6161
"npm:@duckdb/duckdb-wasm/dist/duckdb-browser-eh.worker.js"
6262
])
6363
);
64-
assert.deepStrictEqual(
65-
getImplicitDownloads(["npm:@observablehq/sqlite"]),
66-
new Set(["npm:sql.js/dist/sql-wasm.js", "npm:sql.js/dist/sql-wasm.wasm"])
67-
);
64+
assert.deepStrictEqual(getImplicitDownloads(["npm:sql.js"]), new Set(["npm:sql.js/dist/sql-wasm.wasm"]));
6865
});
6966
});
7067

@@ -74,7 +71,9 @@ describe("getImplicitDependencies(imports)", () => {
7471
assert.deepStrictEqual(getImplicitDependencies(["npm:@observablehq/duckdb"]), new Set(["npm:@duckdb/duckdb-wasm"]));
7572
assert.deepStrictEqual(getImplicitDependencies(["npm:@observablehq/inputs"]), new Set(["npm:htl", "npm:isoformat"])); // prettier-ignore
7673
assert.deepStrictEqual(getImplicitDependencies(["npm:@observablehq/mermaid"]), new Set(["npm:mermaid"]));
74+
assert.deepStrictEqual(getImplicitDependencies(["npm:@observablehq/sqlite"]), new Set(["npm:sql.js"]));
7775
assert.deepStrictEqual(getImplicitDependencies(["npm:@observablehq/tex"]), new Set(["npm:katex"]));
76+
assert.deepStrictEqual(getImplicitDependencies(["observablehq:stdlib/sqlite"]), new Set(["npm:sql.js"]));
7877
assert.deepStrictEqual(getImplicitDependencies(["observablehq:stdlib/xlsx"]), new Set(["npm:exceljs"]));
7978
assert.deepStrictEqual(getImplicitDependencies(["observablehq:stdlib/zip"]), new Set(["npm:jszip"]));
8079
assert.deepStrictEqual(getImplicitDependencies(["observablehq:stdlib/vega-lite"]), new Set(["npm:vega-lite-api", "npm:vega-lite", "npm:vega"])); // prettier-ignore

0 commit comments

Comments
 (0)