frontend: Fix canvas removal causing crashes due to recursive remove calls #12756
+21
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes some changes to how canvas removal is handled to avoid recursion in the middle of an
erase()operation on the vector holding frontend-managed canvases.Also prevents a similar issue when clearing scene data by replacing
.clear()with a dedicated method that also ensures the canvas removal signal is properly fired for each removed canvas.Motivation and Context
See #12728, which this PR superseedes.
How Has This Been Tested?
Reproduced using the following snipped (just added to the end of the
OBSBasicSettings::OBSBasicSettings()constructor):Note that the crash only happens in release builds, not debug.
Types of changes
Checklist: