Network caps to track network access #12787
Draft
+292
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a [Network_cap.t] type which must be passed to the low-level functions which require network access, and should only be created at the "edge", either in a command or a rule. This will make it harder to accidentally add a requirement on network access to a code path that previously did not require network access, which will become important for maintaining an offline mode for Dune where it avoids updating package repositories and downloading files where possible. Signed-off-by: Stephen Sherratt <[email protected]>
gridbugs
force-pushed
the
network-cap
branch
from
a4a2703 to
70b6dc4
Compare
Member
|
Before this PR is considered, can we see where this parameter is used for something? Otherwise, this is a rather large change for something that is fairly niche. I'd like to see if there's a less intrusive way to accomplish this. |
Collaborator
Author
|
Converting to a draft while I flesh out this idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #10508
Adds a [Network_cap.t] type which must be passed to the low-level functions which require network access, and should only be created at the "edge", either in a command or a rule. This will make it harder to accidentally add a requirement on network access to a code path that previously did not require network access, which will become important for maintaining an offline mode for Dune where it avoids updating package repositories and downloading files where possible.