Skip to content

Mocaml.with_printer didn't update replacement_printer_doc #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
voodoos merged 3 commits into from
Dec 5, 2025
Merged

Mocaml.with_printer didn't update replacement_printer_doc #2010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
039df58
Set Format_doc.deprecated
davesnx Dec 4, 2025
82b8ce3
Merge pull request #1 from davesnx/replacement-printer
davesnx Dec 4, 2025
c98e6c9
Add entry for CHANGES
davesnx Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ unreleased
- Fix completion not working for inlined records labels (#1978, fixes #1977)
- Perform buffer indexing only if the query requires it (#1990 and #1991)
- Stop unnecessarily forcing substitutions when initializing short-paths graph (#1988)
- Fix Mocaml.with_printer didn't update replacement_printer_doc (#2010)
+ test suite
- Add a test to ensure the behavior showed in issue #1517 is no longer relevant (#1995)
- Add a test to ensure the code fragment exhibited in issue #1118 no longer makes Merlin crash (#1996)
Expand Down
4 changes: 3 additions & 1 deletion src/kernel/mocaml.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ let default_printer ppf =
| Out_type_extension x -> Format_doc.compat default_out_type_extension ppf x
| Out_phrase x -> default_out_phrase ppf x

let with_printer printer f = let_ref replacement_printer (Some printer) f
let with_printer printer f =
let_ref replacement_printer (Some printer) @@ fun () ->
let_ref replacement_printer_doc (Some (Format_doc.deprecated printer)) f

(* Cleanup caches *)
let clear_caches () =
Expand Down
Loading