Skip to content

Commit ab49043

Browse files
committed
Increased logging and bug fixes
1 parent 5e66990 commit ab49043

File tree

1 file changed

+20
-8
lines changed

1 file changed

+20
-8
lines changed

src/main/java/org/openhab/binding/xiaomigateway/internal/XiaomiGatewayBinding.java

+20-8
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ private void receiveData(MulticastSocket socket, DatagramPacket dgram) {
164164
String sentence = new String(dgram.getData(), 0,
165165
dgram.getLength());
166166

167-
logger.debug("Xiaomi received packet: " + sentence);
167+
logger.info("Xiaomi received packet: " + sentence);
168168

169169
JsonObject jobject = parser.parse(sentence).getAsJsonObject();
170170
String command = jobject.get("cmd").getAsString();
@@ -189,7 +189,6 @@ private void receiveData(MulticastSocket socket, DatagramPacket dgram) {
189189
continue;
190190
}
191191

192-
logger.info("Xiaomi received: " + sentence);
193192
//report and non gateway heartbeat
194193
processOtherCommands(jobject);
195194
}
@@ -243,7 +242,6 @@ private void processOtherCommands(JsonObject jobject) {
243242
}
244243

245244
private void getGatewayInfo(JsonObject jobject) {
246-
//Xiaomi received packet: {"cmd":"iam","port":"9898","sid":"f0b4299a54e4","model":"gateway","ip":"192.168.2.187"}
247245
sid = jobject.get("sid").getAsString();
248246
dest_port = jobject.get("port").getAsInt();
249247
gatewayIP = jobject.get("ip").getAsString();
@@ -413,9 +411,6 @@ protected String getName() {
413411
protected void execute() {
414412
// the frequently executed code (polling) goes here ...
415413
// logger.debug("execute() method is called!");
416-
417-
418-
//requestIdList();
419414
}
420415

421416
private void requestIdList() {
@@ -450,12 +445,28 @@ private void requestWrite(String device, String[] keys, Object[] values) {
450445
byte[] sendData = sendString.getBytes("UTF-8");
451446
InetAddress addr = InetAddress.getByName(gatewayIP);
452447
DatagramPacket sendPacket = new DatagramPacket(sendData, sendData.length, addr, dest_port);
448+
logger.info("Sending to device: " + device + " message: " + sendString );
449+
socket.send(sendPacket);
450+
} catch (IOException e) {
451+
e.printStackTrace();
452+
}
453+
}
453454

455+
/*
456+
private void requestWriteGateway(String device, String[] keys, Object[] values) {
457+
try {
458+
String key = getKey();
459+
String sendString = "{\"cmd\": \"write\", \"model\": \"gateway\", \"sid\": \"" + device + "\", \"short_id\": \"0\", \"key\": \"" + key + "\", \"data\": \"{" + getData(keys, values) + ",\"key\":\\\"" + key + "\\\"}\"}";
460+
byte[] sendData = sendString.getBytes("UTF-8");
461+
InetAddress addr = InetAddress.getByName(gatewayIP);
462+
DatagramPacket sendPacket = new DatagramPacket(sendData, sendData.length, addr, dest_port);
463+
logger.info("Sending to gateway: " + device + " message: " + sendString );
454464
socket.send(sendPacket);
455465
} catch (IOException e) {
456466
e.printStackTrace();
457467
}
458468
}
469+
*/
459470

460471
private String getData(String[] keys, Object[] values) {
461472
StringBuilder builder = new StringBuilder();
@@ -472,15 +483,16 @@ private String getData(String[] keys, Object[] values) {
472483
first = false;
473484

474485
//write key
475-
builder.append("\"").append(k).append("\"").append(": ");
486+
builder.append("\\\"").append(k).append("\\\"").append(": ");
476487

477488
//write value
478489
builder.append(getValue(values[i]));
479490
}
480-
return toString().toString();
491+
return builder.toString();
481492
}
482493

483494
private String getKey() {
495+
logger.info("Encrypting \"" + token + "\" with key \"" + key + "\"" );
484496
return EncryptionHelper.encrypt(token, key);
485497
}
486498

0 commit comments

Comments
 (0)