Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Workflow Runs int overflows #145

Open
1 task done
caleblloyd opened this issue Feb 7, 2025 · 1 comment
Open
1 task done

[BUG]: Workflow Runs int overflows #145

caleblloyd opened this issue Feb 7, 2025 · 1 comment
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@caleblloyd
Copy link

What happened?

await client.Repos[repository.Org!.Alias][repository.Name].Actions.Workflows[workflowId].Runs.GetAsync();

throws

JsonException: The JSON value could not be converted to System.Int32. Path: $ | LineNumber: 0 | BytePositionInLine: 11. FormatException: Either the JSON value is not in a supported format, or is out of bounds for an Int32.

Because workflow runs are far bigger than int.MaxValue

So GitHub.Models.WorkflowRun field Id needs to be updated to long and so does the query paramater anywhere that a GitHub Workflow Run is requested by ID

Versions

octokit/dotnet-sdk:v0.0.31, .NET 8

Code of Conduct

  • I agree to follow this project's Code of Conduct
@caleblloyd caleblloyd added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
Status: 🆕 Triage
Development

No branches or pull requests

1 participant