Commit 099cedd
committed
[FIX] BottomBarSheet: sheet name should update on foreign changes
How to reproduce:
On Firefox,
- double click the bottom bar to rename a sheet
- Undo the change (button or through Ctrl-Z)
=> the sheetName is not rolled back to its previous value
The issue seems to lie in the fact that in FF, setting a t-esc on an
Element that was previously `contenteditable=true` creates weird
behaviour. I suspect some internal state of the div that is not cleared.
On the other hand, changing the contenteditable state of the span
element might not be the best idea and one could consider that it's
safer to simply regenerate the span altogether when switching editing
state.
This commit takes the last suggested approach.
Task: 50162521 parent 5c3234b commit 099cedd
File tree
2 files changed
+22
-3
lines changed- src/components/bottom_bar_sheet
- tests/bottom_bar
2 files changed
+22
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
70 | 74 | | |
71 | 75 | | |
72 | 76 | | |
| |||
346 | 350 | | |
347 | 351 | | |
348 | 352 | | |
349 | | - | |
| 353 | + | |
350 | 354 | | |
351 | 355 | | |
352 | 356 | | |
353 | 357 | | |
354 | 358 | | |
355 | | - | |
356 | | - | |
| 359 | + | |
357 | 360 | | |
358 | 361 | | |
359 | 362 | | |
| |||
371 | 374 | | |
372 | 375 | | |
373 | 376 | | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
374 | 392 | | |
375 | 393 | | |
376 | 394 | | |
| |||
0 commit comments