Skip to content

Commit eb13639

Browse files
committed
[REV] xlsx: make import verbose
This reverts commit e726d26 as this flag makes runbot red due to warnings. closes #7078 Task: 0 X-original-commit: 71808b2 Signed-off-by: Rémi Rahir (rar) <[email protected]> Signed-off-by: Pierre Rousseau (pro) <[email protected]>
1 parent a261873 commit eb13639

File tree

2 files changed

+10
-22
lines changed

2 files changed

+10
-22
lines changed

src/model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ export class Model extends EventBus<any> implements CommandDispatcher {
195195
config: Partial<ModelConfig> = {},
196196
stateUpdateMessages: StateUpdateMessage[] = [],
197197
uuidGenerator: UuidGenerator = new UuidGenerator(),
198-
verboseImport = true
198+
verboseImport = false
199199
) {
200200
const start = performance.now();
201201
console.debug("##### Model creation #####");

tests/model/model.test.ts

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -374,16 +374,10 @@ describe("Model", () => {
374374
const transport = new MockTransportService();
375375
const spy = jest.spyOn(transport, "sendMessage");
376376
const xlsxData = await getTextXlsxFiles();
377-
new Model(
378-
xlsxData,
379-
{
380-
transportService: transport,
381-
client: { id: "test", name: "Test" },
382-
},
383-
undefined,
384-
undefined,
385-
false
386-
);
377+
new Model(xlsxData, {
378+
transportService: transport,
379+
client: { id: "test", name: "Test" },
380+
});
387381
expect(spy).toHaveBeenCalledWith({
388382
type: "SNAPSHOT",
389383
version: MESSAGE_VERSION,
@@ -398,17 +392,11 @@ describe("Model", () => {
398392
const transport = new MockTransportService();
399393
transport.onNewMessage("listener", (message) => messages.push(message));
400394
const xlsxData = await getTextXlsxFiles();
401-
new Model(
402-
xlsxData,
403-
{
404-
transportService: transport,
405-
client: { id: "test", name: "Test" },
406-
mode: "readonly",
407-
},
408-
undefined,
409-
undefined,
410-
false
411-
);
395+
new Model(xlsxData, {
396+
transportService: transport,
397+
client: { id: "test", name: "Test" },
398+
mode: "readonly",
399+
});
412400
expect(messages.map((m) => m.type)).not.toContain("SNAPSHOT_CREATED");
413401
});
414402
});

0 commit comments

Comments
 (0)