prov/efa: Remove unit tests that require handshake for DC

In the new code path, I removed the logic that queues a DC packet until
a handshake has completed.

Going forward, we are targeting backwards compatibiilty up to v2.0
The delivery complete feature was introduced in Libfabric v1.12

Signed-off-by: Sai Sunku <sunkusa@amazon.com>

Author: sunkuamzn

prov/efa/test/efa_unit_test_ep.c

@@ -468,128 +468,6 @@ void test_efa_rdm_ep_dc_atomic_queue_before_handshake(struct efa_resource **stat
 	assert_true(txe->internal_flags & EFA_RDM_OPE_QUEUED_BEFORE_HANDSHAKE);
 }
 
-/**
- * @brief when delivery complete send was used and handshake packet has not been received
- * verify the txe is queued
- *
- * @param[in]	state		struct efa_resource that is managed by the framework
- */
-void test_efa_rdm_ep_dc_send_queue_before_handshake(struct efa_resource **state)
-{
-	struct efa_rdm_ep *efa_rdm_ep;
-	struct efa_rdm_peer *peer;
-	struct fi_msg msg = {0};
-	struct iovec iov;
-	struct efa_resource *resource = *state;
-	struct efa_ep_addr raw_addr = {0};
-	size_t raw_addr_len = sizeof(struct efa_ep_addr);
-	fi_addr_t peer_addr;
-	int err, numaddr;
-	struct efa_rdm_ope *txe;
-
-	/* disable shm to force using efa device to send */
-	efa_unit_test_resource_construct_rdm_shm_disabled(resource);
-
-	/* create a fake peer */
-	err = fi_getname(&resource->ep->fid, &raw_addr, &raw_addr_len);
-	assert_int_equal(err, 0);
-	raw_addr.qpn = 1;
-	raw_addr.qkey = 0x1234;
-	numaddr = fi_av_insert(resource->av, &raw_addr, 1, &peer_addr, 0, NULL);
-	assert_int_equal(numaddr, 1);
-
-	msg.addr = peer_addr;
-	msg.iov_count = 1;
-	iov.iov_base = NULL;
-	iov.iov_len = 0;
-	msg.msg_iov = &iov;
-	msg.desc = NULL;
-
-	efa_rdm_ep = container_of(resource->ep, struct efa_rdm_ep, base_ep.util_ep.ep_fid);
-
-	/* set peer->flag to EFA_RDM_PEER_REQ_SENT will make efa_rdm_atomic() think
-	 * a REQ packet has been sent to the peer (so no need to send again)
-	 * handshake has not been received, so we do not know whether the peer support DC
-	 */
-	peer = efa_rdm_ep_get_peer(efa_rdm_ep, peer_addr);
-	peer->flags = EFA_RDM_PEER_REQ_SENT;
-	peer->is_local = false;
-
-	assert_false(efa_rdm_ep->homogeneous_peers);
-	assert_true(dlist_empty(&efa_rdm_ep->txe_list));
-	err = fi_sendmsg(resource->ep, &msg, FI_DELIVERY_COMPLETE);
-	/* DC has been reuquested, but ep do not know whether peer supports it, therefore
-	 * the ope has been queued to domain->ope_queued_list
-	 */
-	assert_int_equal(err, 0);
-	assert_int_equal(efa_unit_test_get_dlist_length(&efa_rdm_ep->txe_list),  1);
-	assert_int_equal(efa_unit_test_get_dlist_length(&(efa_rdm_ep_domain(efa_rdm_ep)->ope_queued_list)), 1);
-	txe = container_of(efa_rdm_ep_domain(efa_rdm_ep)->ope_queued_list.next, struct efa_rdm_ope, queued_entry);
-	assert_true((txe->op == ofi_op_msg));
-	assert_true(txe->internal_flags & EFA_RDM_OPE_QUEUED_BEFORE_HANDSHAKE);
-}
-
-/**
- * @brief when delivery complete send was used and handshake packet has not been received
- * verify the txes are queued before the number of requests reach EFA_RDM_MAX_QUEUED_OPE_BEFORE_HANDSHAKE.
- * After reaching the limit, fi_send should return -FI_EAGAIN
- *
- * @param[in]	state		struct efa_resource that is managed by the framework
- */
-void test_efa_rdm_ep_dc_send_queue_limit_before_handshake(struct efa_resource **state)
-{
-	struct efa_rdm_ep *efa_rdm_ep;
-	struct efa_rdm_peer *peer;
-	struct fi_msg msg = {0};
-	struct iovec iov;
-	struct efa_resource *resource = *state;
-	struct efa_ep_addr raw_addr = {0};
-	size_t raw_addr_len = sizeof(struct efa_ep_addr);
-	fi_addr_t peer_addr;
-	int err, numaddr;
-	int i;
-
-	/* disable shm to force using efa device to send */
-	efa_unit_test_resource_construct_rdm_shm_disabled(resource);
-
-	/* create a fake peer */
-	err = fi_getname(&resource->ep->fid, &raw_addr, &raw_addr_len);
-	assert_int_equal(err, 0);
-	raw_addr.qpn = 1;
-	raw_addr.qkey = 0x1234;
-	numaddr = fi_av_insert(resource->av, &raw_addr, 1, &peer_addr, 0, NULL);
-	assert_int_equal(numaddr, 1);
-
-	msg.addr = peer_addr;
-	msg.iov_count = 1;
-	iov.iov_base = NULL;
-	iov.iov_len = 0;
-	msg.msg_iov = &iov;
-	msg.desc = NULL;
-
-	efa_rdm_ep = container_of(resource->ep, struct efa_rdm_ep, base_ep.util_ep.ep_fid);
-
-	/* set peer->flag to EFA_RDM_PEER_REQ_SENT will make efa_rdm_atomic() think
-	 * a REQ packet has been sent to the peer (so no need to send again)
-	 * handshake has not been received, so we do not know whether the peer support DC
-	 */
-	peer = efa_rdm_ep_get_peer(efa_rdm_ep, peer_addr);
-	peer->flags = EFA_RDM_PEER_REQ_SENT;
-	peer->is_local = false;
-
-	assert_false(efa_rdm_ep->homogeneous_peers);
-	assert_true(dlist_empty(&efa_rdm_ep->txe_list));
-
-	for (i = 0; i < EFA_RDM_MAX_QUEUED_OPE_BEFORE_HANDSHAKE; i++) {
-		err = fi_sendmsg(resource->ep, &msg, FI_DELIVERY_COMPLETE);
-		assert_int_equal(err, 0);
-	}
-
-	assert_true(efa_rdm_ep->ope_queued_before_handshake_cnt == EFA_RDM_MAX_QUEUED_OPE_BEFORE_HANDSHAKE);
-	err = fi_sendmsg(resource->ep, &msg, FI_DELIVERY_COMPLETE);
-	assert_int_equal(err, -FI_EAGAIN);
-}
-
 /**
  * @brief verify tx entry is queued for rma (read or write) request before handshake is made.
  *

prov/efa/test/efa_unit_tests.c

@@ -178,8 +178,7 @@ int main(void)
 		cmocka_unit_test_setup_teardown(test_efa_rdm_ep_rx_pkt_pool_flags, efa_unit_test_mocks_setup, efa_unit_test_mocks_teardown),
 		cmocka_unit_test_setup_teardown(test_efa_rdm_ep_pkt_pool_page_alignment, efa_unit_test_mocks_setup, efa_unit_test_mocks_teardown),
 		cmocka_unit_test_setup_teardown(test_efa_rdm_ep_dc_atomic_queue_before_handshake, efa_unit_test_mocks_setup, efa_unit_test_mocks_teardown),
-		cmocka_unit_test_setup_teardown(test_efa_rdm_ep_dc_send_queue_before_handshake, efa_unit_test_mocks_setup, efa_unit_test_mocks_teardown),
-		cmocka_unit_test_setup_teardown(test_efa_rdm_ep_dc_send_queue_limit_before_handshake, efa_unit_test_mocks_setup, efa_unit_test_mocks_teardown),
+
 		cmocka_unit_test_setup_teardown(test_efa_rdm_ep_read_queue_before_handshake, efa_unit_test_mocks_setup, efa_unit_test_mocks_teardown),
 		cmocka_unit_test_setup_teardown(test_efa_rdm_ep_write_queue_before_handshake, efa_unit_test_mocks_setup, efa_unit_test_mocks_teardown),
 		cmocka_unit_test_setup_teardown(test_efa_rdm_ep_trigger_handshake, efa_unit_test_mocks_setup, efa_unit_test_mocks_teardown),

prov/efa/test/efa_unit_tests.h

@@ -163,8 +163,7 @@ void test_efa_rdm_ep_tx_pkt_pool_flags();
 void test_efa_rdm_ep_rx_pkt_pool_flags();
 void test_efa_rdm_ep_pkt_pool_page_alignment();
 void test_efa_rdm_ep_dc_atomic_queue_before_handshake();
-void test_efa_rdm_ep_dc_send_queue_before_handshake();
-void test_efa_rdm_ep_dc_send_queue_limit_before_handshake();
+
 void test_efa_rdm_ep_write_queue_before_handshake();
 void test_efa_rdm_ep_read_queue_before_handshake();
 void test_efa_rdm_ep_trigger_handshake();