[ENG-925] removed encounter_class_history field (#3743)

* removed encounter_class_history field

* fixed migrations

* added validation to disallow encounter class change

* Remove encounter class from update spec

---------

Co-authored-by: vigneshhari <vichuhari100@gmail.com>

Author: praffq

care/emr/admin/encounter.py

@@ -41,7 +41,6 @@ class Meta:
             "status",
             "status_history",
             "encounter_class",
-            "encounter_class_history",
             "patient",
             "period",
             "facility",

care/emr/migrations/0082_remove_encounter_encounter_class_history.py

@@ -0,0 +1,17 @@
+# Generated by Django 6.0 on 2026-08-18 17:37
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('emr', '0081_facilitylocation_tags'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='encounter',
+            name='encounter_class_history',
+        ),
+    ]

care/emr/models/encounter.py

@@ -12,7 +12,6 @@ class Encounter(EMRBaseModel):
     status = models.CharField(max_length=100, null=True, blank=True)
     status_history = models.JSONField(default=dict)
     encounter_class = models.CharField(max_length=100, null=True, blank=True)
-    encounter_class_history = models.JSONField(default=dict)
     patient = models.ForeignKey("emr.Patient", on_delete=models.CASCADE)
     period = models.JSONField(default=dict)
     facility = models.ForeignKey("facility.Facility", on_delete=models.PROTECT)

care/emr/resources/encounter/spec.py

@@ -62,7 +62,6 @@ class EncounterSpecBase(EMRResource):
 
     id: UUID4 = None
     status: StatusChoices
-    encounter_class: ClassChoices
     period: PeriodSpec = {}
     hospitalization: HospitalizationSpec | None = {}
     priority: EncounterPriorityChoices
@@ -75,6 +74,7 @@ class EncounterCreateSpec(ExtensionValidator, EncounterSpecBase):
     facility: UUID4
     organizations: list[UUID4] = []
     appointment: UUID4 | None = None
+    encounter_class: ClassChoices
 
     def perform_extra_deserialization(self, is_update, obj):
         if not is_update:
@@ -95,11 +95,6 @@ def perform_extra_deserialization(self, is_update, obj):
             obj.status_history = {
                 "history": [{"status": obj.status, "moved_at": str(timezone.now())}]
             }
-            obj.encounter_class_history = {
-                "history": [
-                    {"status": obj.encounter_class, "moved_at": str(timezone.now())}
-                ]
-            }
 
 
 class EncounterUpdateSpec(ExtensionValidator, EncounterSpecBase):
@@ -109,10 +104,6 @@ def perform_extra_deserialization(self, is_update, obj):
             obj.status_history["history"].append(
                 {"status": self.status, "moved_at": str(timezone.now())}
             )
-        if old_instance.encounter_class != self.encounter_class:
-            obj.encounter_class_history["history"].append(
-                {"status": self.status, "moved_at": str(timezone.now())}
-            )
         if self.discharge_summary_advice is None and is_update:
             obj.discharge_summary_advice = None
 
@@ -121,12 +112,12 @@ class EncounterListSpec(EncounterSpecBase):
     patient: dict
     facility: dict
     status_history: dict
-    encounter_class_history: dict
     created_date: datetime.datetime
     modified_date: datetime.datetime
     tags: list[dict] = []
     current_location: dict | None = None
     care_team: list[dict] = []
+    encounter_class: ClassChoices
 
     @classmethod
     def perform_extra_serialization(cls, mapping, obj):

care/emr/tests/test_encounter_api.py

@@ -42,8 +42,8 @@ def setUp(self):
             patient=self.patient,
             facility=self.facility,
             organization=self.facility_organization,
+            encounter_class=ClassChoices.imp.value,
             status_history={"history": []},
-            encounter_class_history={"history": []},
         )
         self.client.force_authenticate(user=self.user)
         self.url = reverse("encounter-list")
@@ -929,8 +929,8 @@ def setUp(self):
             patient=self.patient,
             facility=self.facility,
             organization=self.facility_organization,
+            encounter_class=ClassChoices.imp.value,
             status_history={"history": []},
-            encounter_class_history={"history": []},
         )
         self.client.force_authenticate(user=self.user)
         self.url = reverse("encounter-list")

care/emr/tests/test_medication_dispense_api.py

@@ -36,7 +36,6 @@ def setUp(self):
             facility=self.facility,
             organization=self.facility_organization,
             status_history={"history": []},
-            encounter_class_history={"history": []},
         )
         self.supplier = self.create_organization(name="Test Supplier")
         self.location = self.create_facility_location(