You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found this package while searching the internet for semantic versioning packages. However, after looking at your code, I realized that your version comparison functions don't implement the necessary functionality to comply with the specification mentioned in your README file.
There are a few parts of the spec you don't seem to have implemented:
Integral portions of the version need to be compared numerically. For example, v1.0.0-beta.2 is less than v1.0.0-beta.11/
Pre-release versions should have lower precedence than release versions. For example, v1.0.0-rc.1 is less than v1.0.0.
The following tests can be added to your TestGreaterThan() function to represent the two points above:
I found this package while searching the internet for semantic versioning packages. However, after looking at your code, I realized that your version comparison functions don't implement the necessary functionality to comply with the specification mentioned in your README file.
There are a few parts of the spec you don't seem to have implemented:
v1.0.0-beta.2
is less thanv1.0.0-beta.11
/v1.0.0-rc.1
is less thanv1.0.0
.The following tests can be added to your
TestGreaterThan()
function to represent the two points above:The text was updated successfully, but these errors were encountered: