Skip to content

[Bug]: Error when unzipping #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
isarandrei opened this issue Mar 6, 2025 · 5 comments
Closed
1 task done

[Bug]: Error when unzipping #345

isarandrei opened this issue Mar 6, 2025 · 5 comments
Assignees
Labels

Comments

@isarandrei
Copy link

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

OpenComic Version

1.4.3

Operating System

macOS Sequoia 15.3.1

Installed via

App Store

Steps to reproduce

  1. Open any directory that contains archived files or directly any archived file
  2. The error message appears

Expected Behavior

I would expect that I see the thumbnails for any library item that is an archive and that I can directly read archives file without having to manually unarchived it.

Actual Behavior

I see the error message and I can't read archive files.

Error message

An error occurred while trying to unzip the file.
spawn /Applications/OpenComic.app/Contents/Resources/app.asar.unpacked/node_modules/7zip-bin/mac/arm64/7za EACCES

Additional Information

I tried with .zip and .cbz archives.
Before I started using the version from App Store I used the one manually installed from GitHub and it worked correctly.

Sample file

No response

@isarandrei isarandrei added the bug label Mar 6, 2025
@ollm ollm self-assigned this Mar 6, 2025
@ollm
Copy link
Owner

ollm commented Mar 6, 2025

Thanks for reporting!

From the error message it seems that the 7zip binary built into OpenComic (which is used to extract zip and 7z files) does not have the correct permissions, I will send an update to App Store as soon as possible with a fix.

@isarandrei
Copy link
Author

Thank you for the swift response. I will try the update when is available and report back.

@ollm
Copy link
Owner

ollm commented Mar 6, 2025

It seems to be a bug with electron-builder (Used to build the app), which is changing the permissions of the 7zip binary when build for macOS (For store builds only), I have opened a bug report in their repository electron-userland/electron-builder#8943

To fix this on my side, I've added postbuild tests on macOS to detect incorrect permissions 66c845c and made some changes to fix the problem temporarily cc606e7 (Although this fix it could be used permanently)

I've already submitted the version with the fix to the App Store, but we still have to wait for Apple to review the update and approve it.

I will let you know when it is available.

@ollm
Copy link
Owner

ollm commented Mar 11, 2025

Sorry for the delay, the new version is now available (v1.4.12), I had some issues with Apple's App Review Team and in the end I had to remove 2 read/write permissions 5b88bd4 among some other changes requested.

The app should work almost the same without them, since it is prepared to use Accessing Security Scoped Resource, but there could still be some bug related to read/write permissions, and a couple of functions that don't work properly because of it.

Let me know how this version works.

@isarandrei
Copy link
Author

I tried opening archives and it works great, not sure if there are issues but I couldn't find any. Thank you for the fix and have a nice rest of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants