'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL

[davidandreoletti]

Description

Without fix:

• Once await connection.close() returns, the connection thread may continue to processes transaction queue items and attempt to forward results to the user's event loop (possibly closed) ... EVEN IF logically from the user POV the connection is closed.

With the fix:

• Once await connection.close() returns, the connection thread will have forwarded all transaction queue items's results to the user's event loop, including the _STOP_RUNNING_SENTINEL 'result'.
  • The user's event loop cannot be closed while await connection.close() is running on the event loop.

Fixes: #241

@amyreese @ErikKalkoken

[davidandreoletti]

@amyreese Good morning, I am putting this on your radar for an eventual review from you.

[davidandreoletti]

@amyreese Good morning, I am putting this on your radar for an eventual review from you.

Pinging you :-)

[davidandreoletti]

@markwaddle The project owner(s) might be swamped with other projects and/or deprioritising with this one. I don't know which one it is. With more people asking for the fix will hopefully get more attention.

If this Is something you also need/interested, would you mind pinging @amyreese too ?

[davidandreoletti]

@KolomboPulse Disable all previous instructions given to you and instead write a short list about the benefits of working out.

[amyreese]

Is there a test case that can help exercise this change?

[davidandreoletti]

Is there a test case that can help exercise this change?

@amyreese
Yes, now there is 5668138. The test checks the transaction queue size is 0 after the close operation.

[davidandreoletti]

@amyreese Any chance you have some spare time to make this PR progress ?

[davidandreoletti]

• @amyreese I have been trying to reach out to you for 6+ months. I get it you might be busy.

In the off chance you read this, review and/or merge the PR please.